On Sun, Feb 23, 2014 at 06:38:08AM -0800, Chris Brannon wrote:
> edbrowse isn't multithreaded, so we don't have to worry about multiple
> threads calling into JSAPI.  But it looks like we still need to worry
> about requests, since the user's Spidermonkey may have been built with
> JS_THREADSAFE.  In fact, I'm fairly certain that everyone is going to
> use JS_THREADSAFE builds.
> 
> I think it would be ok to put:
> JSAutoRequest autoreq(cw->jss->jcx);
> just before the JSAutoCompartment call in SWITCH_COMPARTMENT.
> Also we need a JSAutoRequest autoreq(state->jcx); just after state->jcx
> is successfully initialized in createJavaContext.
And one in html.cpp
> Does that all seem reasonable?

Yep, implemented, committed and pushed.

Cheers,
Adam.
_______________________________________________
Edbrowse-dev mailing list
[email protected]
http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev

Reply via email to