On Sun, Feb 23, 2014 at 05:57:11PM -0500, Karl Dahlke wrote: > > Out of interest are there really cases where the error number > > doesn't reflect the out of memory condition but the message does? > > I think the memory hog test in jsrt is one such.
That's really annoying. I've got nothing against taking actions based on the error number as (if I understand the mechanism correctly) this is dependant on the type of error. However, doing things based on the error message (which I think comes from exceptions, user thrown or otherwise) seems a bit more fragile to me. If we don't do this I wonder if it's really such a bad thing since the exception will stop the current script (at least if it makes it to our error reporter), and then js will fail on the next call to one of our functions which uses javaSessionFail anyway. As far as I can tell from the way mozjs behaves, the worst that'll happen is the user'll see a bunch of out of memory errors until something gets called which calls javaSessionFail. As long as we make sure *all* our js stuff behaves correctly in terms of handling errors we shouldn't have a problem with this particular condition causing segfaults I think. What does everyone else think? Cheers, Adam. _______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
