On Mon, Apr 13, 2015 at 04:33:57PM -0400, Karl Dahlke wrote: > > but I'd like it if the type attribute was optional > > I was looking at this stuff and asked myself, "what the hell is type for?" > It is used nowhere, except one place, where the string > is copied into a mime object in the js world. > There is such an object for each mime entity in the config file. > That object wants a type attribute, I don't know what for. > We could probably do without it just fine, > or maybe just copy the description in there.
I'd probably put the content type in there actually since that seems the most logical thing to go into the type attribute of a mime object to me. If this is unspecified then just don't create a mime object for that plugin. > > I'd also probably rename this as plugin since it's now more than just mime > > type handlers. > > I think that's a great idea, will probably do that > unless someone objects. > Not sure if I will retroactively change all the variables in the source code, > but at least the config file syntax. Thanks, I think the variables can be altered either now or later depending on how these plugins are used in a given context, e.g. in some situations the mime naming may make sense. > > Should this be plugin.c rather than mime.c? > > Yes I think so, I'll do a git rename soon. > That's easy. Thanks. As well as altering the Makefiles etc. Cheers, Adam.
signature.asc
Description: Digital signature
_______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
