On Thu, Apr 23, 2015 at 03:51:22AM -0400, Karl Dahlke wrote: > Ok - I went back to opendir readder etc and it fixes your bug, > broken symlinks now appear. > And it's less code than setting up for glob().
Yeah, this is a good change I think. > I still need glob for expanding wildcards in filenames. > No mistake about that. > My home grown version wasn't very good. > It only expanded wildcards at the end, not the middle of the path. > So I'm glad we did this work, but as for a simple directory scan, > as Adam pointed out, glob is overkill - > and it did introduce at least one small bug. We also get full globbing this way (i.e. character ranges and the ? metacharacter). > With the scan back under our control, the sort is also under our control. > I use strcmp because it's easy, but should I be using strcoll? > In other words, should the sort always be ascii coalating, > or should the user be able to control it through his LC variables? > Maybe in an ideal world it should run like ls, however that sorts, > and maybe that's what strcoll would do, I'm not sure. Yeah we should really be using strcoll in this case. The call is exactly the same as strcmp and it's just as portable according to the standards. Cheers, Adam.
signature.asc
Description: Digital signature
_______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
