On Sun, Jun 14, 2015 at 05:11:05AM -0400, Karl Dahlke wrote: > Ok - URL setters are now in startwindow.js. > I verified that the setter syntax and invokation etc works in d8, > so I believe it is sufficiently generic. > I traded 400 lines of awkward bug-prone confusing engine-specific C > for 100 lines of plain javascript. > That's another 400 lines you won't have to convert when switching to duktape. > jsrt runs, and it contains a lot of url side effects testing. > I don't think I broke anything.
Ok, sent previous message before receiving this one, but my point about DOM specs still stands. > It may also be worth moving the document.cookie setter out of native C > and into js, though a small part of it must remain native to push > the cookie back to edbrowse and curl and the jar. Why? If we've got to retain native parts of this I see no particularly good reason to change it. Just because we *can* change code into a new (to us) shiny language doesn't necessarily mean we should. In fact, I'll probably need to role back some of the startwindow stuff as part of putting together a working DOM. Of course, this isn't confirmed, and I'd need to see how the new parser looks before I know what needs to be changed. Cheers, Adam.
signature.asc
Description: Digital signature
_______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
