I think I've read mixed messages on what needs to be there, and that's why I ended up with something redundant. It's confusing at the source. I think last year I had the getComputedStyle returning a CSSStyleDeclaration object, not just one of its properties. I changed it yesterday because this usage:

document.defaultView.getComputedStyle(penultimate, '').whiteSpace

Suggests to me that the return value from getComputedStyle needs to be solely the CSSStyleDeclaration.style. I was getting an error from the test #0 code yesterday when I returned the object, because I am off by one hop. .whiteSpace exists, but it is located at CSSStyleDeclaration.style.whiteSpace. I ended up with a muddle because I don't know which to do. The documentation for window.getComputedStyle says "The returned style is a live CSSStyleDeclaration object, which updates itself automatically when the element's style is changed." Automatic updating is what the test is about I think. But do we have to code something extra to make it work that way?

So here is a way of turning this into a specific question. Is there a common thing in OOP where, if you just address the object on its own, it is the same as calling a particular method that has been designated as the default? I don't remember the name for this but I feel like it exists. And the thing that would resolve what to do would be if this expression:

.getComputedStyle(penultimate, '').whiteSpace

Would actually reroute you under the hood to:

.getComputedStyle(penultimate, '').getPropertyValue(whiteSpace)

That's what I want to do - designate getPropertyValue to be the method that runs if nothing has been specified. Is this a getter? Is this a familiar idiom to anyone?

thanks
Kevin





 On Mon, 14 Aug 2017, Karl Dahlke wrote:

I went ahead and pushed this patch because it does no harm and moves you 
forward, but it still confuses me.
Your getComputedStyle function at line 759 is equivalent to

function getComputedStyle(e, p) { return e.style; }

The obj variable is local and goes away when the function returns.
So why not write it my way it's a whole lot easier to understand. Unless I'm 
missing something.

Karl Dahlke
_______________________________________________
Edbrowse-dev mailing list
[email protected]
http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev


--------
Kevin Carhart * 415 225 5306 * The Ten Ninety Nihilists
_______________________________________________
Edbrowse-dev mailing list
[email protected]
http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev

Reply via email to