On Thu, Feb 15, 2018 at 06:56:35AM -0500, Karl Dahlke wrote:
> To recap, I created a nightmare with css parsing and querySelectorAll, 
> because we had to, because some websites need it,
> then I fixed the nightmare, so it doesn't bog down every site you look at.
> With this in mind, and the other changes in the past few months, I think we 
> should stabilize, then stamp a new version.
> Fix bugs or make small enhancements (these are often the same thing), sure,
> but no more major redesigns until 3.7.2.

Yeah sounds like a good idea.  To that end there're a couple of small fixes 
which we need:
- a form with an action of "" (or empty) is, as I recall, supposed to use the 
current url as its destination
(at least that's the behaviour I remember and on 
https://www.eaglemusicshop.com/ with the add to basket buttons)
- On that site there's also a button used as a link running the onclick code to 
send the browser to a new page.
That currently fails with the quite correct message that the button isn't part 
of a form.  I think we're
supposed to run the onclick code (or any click events) in any case.

> Adam I still think we could put your gopher changes in, if you're up for 
> that, I don't view that as a major redesign.
> That would be a good thing to have.
> But if you think that might not happen for a couple months then maybe move it 
> to the next version.

I think we set a time (subject to a bit of change) and if I've got something 
working then it goes in,
otherwise not.  We really need the current changes so they get priority.  If I 
miss with the gopher
stuff then that's a shame but not much more.

I've also removed a few unused things today as tidy-up.  I'm currently 
wondering where the mail server socket from
the mail sending mechanism is used as I can only find (with grep) a reference 
to it being defined and declared
as an extern but no actual usage.
I'm guessing it's actually used and don't use that part of the code so I'm not 
touching it.

Other than that, I'm not sure what else we need to sort, there may be a few 
more major changes we want,
but as previously stated, I think we need the css and query selector stuff 
quite urgently.

Cheers,
Adam.
_______________________________________________
Edbrowse-dev mailing list
[email protected]
http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev

Reply via email to