I'm glad it was a one character change. I like the way those parseURL arguments for the URL sections are done. I don't think I have spent much time in url.c. It's nice that the phrasing of the "resolve" debugPrints nailed down where the problem was. I thought at first that it might be handleable by one of those Tidy Opt settings.



---------- Forwarded message ----------
Date: Mon, 01 Jul 2019 00:43:43 -0400
From: Karl Dahlke <[email protected]>
To: [email protected]
Subject: [edbrowse-dev] resolveURL question

resolveURL seems like such a simple routine, but it has been a nightmare for 
about 15 years now.
That's why I have specific debug prints for it, at level 5, probably should be 
at level 4.
We need to see what it is doing and when it screwes up, like here.

The section you refer to is not relevant.
rel is the variable of the relative piece, and that code is for
rel = #foo
where I'm just changing the hash.
But here we have a new path, and the base has a hash, but the hash contains a 
slash, which I've never seen before.
parseURL handles it properly, so let's step through and see what goes wrong.
Line 885 is telling us where the problem is.
Fortunately the fix is literally a single character.

Karl Dahlke

Reply via email to