Hi Ryan, These changes sound good to me. I think the stack protector flag is already in the BaseTools repository (but has not been synced yet with EDK2 repository). And some of the ARMLINUXGCC flags you added are similar to my ARMGCC recent patches so I think I will move all these common flags to the macro GCC_ARMGCC_CC_FLAGS.
Reviewed-by: Olivier Martin <[email protected]> If no one as any comments on Ryan's patch and my recent BaseTools patches I will commit both contributions to BaseTools repository as there are ARM specific. Thanks again for your contribution, Olivier -----Original Message----- From: Ryan Harkin [mailto:[email protected]] Sent: 01 October 2012 10:20 To: [email protected] Subject: [edk2-buildtools] [PATCH] Fix tools_def.template for ARMLINUXGCC Dear EDK2 BaseTools team, Please find attached a patch to fix builds using ARMLINUXGCC version 4.6.3. - GCC 4.6 turns the stack protector on by default. This patch disables it. - some BSPs require unaligned accesses to be disabled Regards, Ryan ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ edk2-buildtools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
