Since you use git, maybe you could use git send-email, since it makes it easier to code-review, and then reply and reference particular code in the patch?
Sent twice, but they look the same. Is that right? Maybe an ASSERT (FoundText) at the end of the routine? For comments, we usually like to waste 2 extra lines with empty // comments. :) FoundText == FALSE => !FoundText Reviewed-by: Jordan Justen <[email protected]> On Tue, Jun 11, 2013 at 3:04 AM, Olivier Martin <[email protected]> wrote: > Dear EDK2 BaseTools maintainers, > > Please find this patch that fixes the calculation of the PE/COFF header > attribute ‘BaseOfCode’ when the first ‘.text’ section is aligned. > > In the current code base, the alignment of the first code section is not > taken into account for the calculation of BaseOfCode. > > Regards, > > Olivier > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > edk2-buildtools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ edk2-buildtools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
