Yes, we may need provide more error messages to user if architectures don't match. But the patch you provided prints a warning message and build doesn't break.
Best Regards, Dennis -----Original Message----- From: Olivier Martin [mailto:[email protected]] Sent: Thursday, October 31, 2013 1:54 PM To: Liu, Yingke D; [email protected] Subject: RE: [edk2-buildtools] [PATCH] BaseTools/AutoGen: Use the defined architecture when only one is defined by the DSC file That was my point. My change was mainly to improve the user experience of the BaseTools by avoiding the user to provide information that the platform he is building already defines. ________________________________________ From: Liu, Yingke D [[email protected]] Sent: 31 October 2013 02:56 To: Olivier Martin; [email protected] Subject: RE: [edk2-buildtools] [PATCH] BaseTools/AutoGen: Use the defined architecture when only one is defined by the DSC file Olivier, If an arch specified by command line doesn't match the arch in DSC file, tool should break even if DSC file only contains a single arch. And self.ArchList might be empty if TARGET_ARCH in target.txt is set to empty. Best Regards, Dennis -----Original Message----- From: Olivier Martin [mailto:[email protected]] Sent: Thursday, October 31, 2013 7:58 AM To: [email protected] Subject: [edk2-buildtools] [PATCH] BaseTools/AutoGen: Use the defined architecture when only one is defined by the DSC file Dear BaseTools maintainers, please find this patch that allows to skip the '-a <ARCH>' parameters when the DSC file contains a single architecture. Note: 'self.ArchList' is always defined because it contains the architecture defined by Conf/target.txt. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin <[email protected]> Regards, Olivier -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk _______________________________________________ edk2-buildtools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
