On Fri, Nov 8, 2013 at 9:50 PM, Jordan Justen <[email protected]> wrote: > On Fri, Nov 8, 2013 at 6:06 AM, Kirkendall, Garrett > <[email protected]> wrote: >> >> I verified with ARMGCC and booted. I did a build of >> MdeModulePkg/MdeModulePkg.dsc >> with GCC47 and the ld commands worked without a problem and I checked that >> HelloWorld.efi was produced.
I verified OVMF IA32 & X64 built with GCC47 is functional with this change. Not a big surprise. >> I looked at ld --help for gnu ld version 2.13.2.1 (2002) >> and it claims to support --start-group and --end-group, so I assume it will >> work properly >> in most any ld more recent than that. > > I can't remember where, but it seemed like this was a problem for > binutils somewhere. It would have been 3~4 years ago. > > It seems like it might have been mingw (UNIXGCC) on windows or OSX. > Hmm, I'm thinking OSX is the more likely suspect. I don't think this will be an issue for GCC44-47. A bit of searching seemed to turn up some references to 'non-GNU' ld not supporting --start-group. Not sure how this might impact edk2. Can someone check UNIXGCC on OS X? I don't think we deprecated UNIXGCC, even though GCC44+ is a better option on Linux, and I think XCLANG is a better option on OS X. -Jordan >> From: Gao, Liming [mailto:[email protected]] >> Sent: Friday, November 08, 2013 2:03 AM >> To: Kirkendall, Garrett; [email protected] >> Subject: RE: [edk2-buildtools] [2nd Request] [PATCH] >> BaseTools/Conf/build_rule.template: modify GCC link commands to be more OS >> agnostic >> >> >> >> Hi: >> >> This change is good to me. Have you verified it in GCC and ARMGCC? >> >> >> >> Thanks >> >> Liming >> >> From: Kirkendall, Garrett [mailto:[email protected]] >> Sent: Thursday, November 7, 2013 10:10 PM >> To: [email protected] >> Subject: [edk2-buildtools] [2nd Request] [PATCH] >> BaseTools/Conf/build_rule.template: modify GCC link commands to be more OS >> agnostic >> >> >> >> Does anyone see a potential problem with this change? No one has responded >> with any input or accepted the change. >> >> >> >> Garrett Kirkendall >> SMTS Firmware Engineer | AMD Technology & Engineering >> 7171 Southwest Parkway, Austin, TX 78735 USA >> O +(1) 512-602-3255 >> facebook | amd.com >> >> >> >> From: Kirkendall, Garrett >> Sent: Wednesday, October 16, 2013 11:28 AM >> To: [email protected] >> Subject: [edk2-buildtools] [PATCH] BaseTools/Conf/build_rule.template: >> modify GCC link commands to be more OS agnostic >> >> >> >> Dear BaseTools maintainers, >> >> >> >> Please consider the attached patch that allows GCC ld to run under Windows >> while using the archive command-line parameters. The short version options >> are replaced with the long version options. When running ld directly under >> Windows it doesn’t require the “(“ or “)” to be escaped. Changing to the >> long version should make the commands safe for Linux and Windows. >> >> >> >> Garrett Kirkendall >> SMTS Firmware Engineer | AMD Technology & Engineering >> 7171 Southwest Parkway, Austin, TX 78735 USA >> facebook | amd.com >> >> >> >> >> ------------------------------------------------------------------------------ >> November Webinars for C, C++, Fortran Developers >> Accelerate application performance with scalable programming models. Explore >> techniques for threading, error checking, porting, and tuning. Get the most >> from the latest Intel processors and coprocessors. See abstracts and register >> http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk >> _______________________________________________ >> edk2-buildtools-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel >> ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ edk2-buildtools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
