Dear BaseTools maintainers,

Please find the attached patches that fix BaseTools.



# 0001: BaseTools: Rectify use of @ in .BAT files.

 

Tracing of the .BAT files is obscured by use of the @ prefix

and is confused by the "echo on" at the end of toolsetup.bat.

 

Silent all the 'echo' with '@'. And remove '@' from the non

'echo' line to make easier to trace the batch files when 'echo on'.

 

# 0002: edksetup.bat: Fixed corrupts CYGWIN_HOME

 

The .BAT file checks for existence of the directory c:\cygwin and,

if it exists, always resets CYGWIN_HOME to that path.

That means that if CYGWIN_HOME is set to say c:\cygwin64, it gets corrupted.

 

# 0003: BaseTools/toolsetup.bat: Basetools corrupts PYTHONPATH

 

The PYTHONPATH variable is used globally by Python, but is corrupted by
toolsetup.bat

that means that downstream invocation of python scripts may fail as they
will

not be able to find library modules.

The basic fix is to use set
PYTHONPATH=%BASETOOLS_PYTHON_SOURCE%;%PYTHONPATH%

 

# 0004: BaseTools: Add the latest versions of Visual Studio to build

 

Both edksetup.bat and BaseTools/toolsetup.bat had chunks of code to

identify the version of Visual Studio from the environment.

They both needed updating to allow for more recent versions.

To simplify future maintenance a common .bat file is added and

used by both.


Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Olivier Martin <[email protected]>



Regards,

Olivier

Attachment: 0002-edksetup.bat-Fixed-corrupts-CYGWIN_HOME.patch
Description: Binary data

Attachment: 0003-BaseTools-toolsetup.bat-Basetools-corrupts-PYTHONPAT.patch
Description: Binary data

Attachment: 0004-BaseTools-Add-the-latests-versions-of-Visual-Studio-.patch
Description: Binary data

Attachment: 0001-BaseTools-Rectify-use-of-in-.BAT-files.patch
Description: Binary data

------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
edk2-buildtools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel

Reply via email to