On 02/14/14 19:49, Ed Maste wrote: > On FreeBSD uname -a reports 'amd64' for the 64-bit x86 architecture. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ed Maste <[email protected]> > --- > BaseTools/Source/C/GNUmakefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/C/GNUmakefile b/BaseTools/Source/C/GNUmakefile > index 124517b..6aa37e4 100644 > --- a/BaseTools/Source/C/GNUmakefile > +++ b/BaseTools/Source/C/GNUmakefile > @@ -19,7 +19,7 @@ ifndef ARCH > # > > uname_m = $(shell uname -m) > > $(info Attempting to detect ARCH from 'uname -m': $(uname_m)) > > - ifeq ($(uname_m),x86_64) > > + ifneq (,$(strip $(filter $(uname_m), x86_64 amd64))) > > ARCH=X64 > > endif > > ifeq ($(patsubst i%86,IA32,$(uname_m)),IA32) >
I can see there have not been any reviews... Maybe try reposting to edk2-buildtools-devel. In any case this seems OK to me, after consulting the GNU make docs. Reviewed-by: Laszlo Ersek <[email protected]> (My r-b may not count much for BaseTools of course :)) Laszlo ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ edk2-buildtools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
