On 05/19/14 23:27, Jordan Justen wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jordan Justen <[email protected]>
> ---
> OvmfPkg/ResetVector/Bin/ResetVector.inf | 29 ------------
> OvmfPkg/ResetVector/Bin/ResetVector.x64.raw | Bin 628 -> 0 bytes
> OvmfPkg/ResetVector/Build.py | 58
> ------------------------
> OvmfPkg/ResetVector/Tools/FixupForRawSection.py | 26 -----------
> 4 files changed, 113 deletions(-)
> delete mode 100644 OvmfPkg/ResetVector/Bin/ResetVector.inf
> delete mode 100644 OvmfPkg/ResetVector/Bin/ResetVector.x64.raw
> delete mode 100644 OvmfPkg/ResetVector/Build.py
> delete mode 100644 OvmfPkg/ResetVector/Tools/FixupForRawSection.py
Before the patchset, we have the following files (not listing
directories, because empty directories are killed by git anyway, as far
as I remember):
1 OvmfPkg/ResetVector/Bin/ResetVector.inf
2 OvmfPkg/ResetVector/Bin/ResetVector.x64.raw
3 OvmfPkg/ResetVector/Build.py
4 OvmfPkg/ResetVector/Ia32/PageTables64.asm
5 OvmfPkg/ResetVector/ResetVectorCode.asm
6 OvmfPkg/ResetVector/Tools/FixupForRawSection.py
This patch removes files 1, 2, 3, and 6. We're left with:
4 OvmfPkg/ResetVector/Ia32/PageTables64.asm
5 OvmfPkg/ResetVector/ResetVectorCode.asm
File 4 is important to keep because that's where we build our page
tables on X64 at runtime. It continues to be referenced by the new files
added in this patchset.
I think file 5 ("OvmfPkg/ResetVector/ResetVectorCode.asm") should be
removed in this patch -- it is not, currently. The new file
"OvmfPkg/ResetVector/ResetVector.nasmbin" from patch 3 replaces it (with
identical contents).
In addition, only Build.py (file 3) references ResetVectorCode.asm (file
5), and this patch removes file 3, hence file 5 becomes unreferenced.
(I think you may have removed it from your working copy, but maybe not
from the index; hance the commit might have missed it. (Ie. you probably
did only "rm", and not "git rm".))
Thanks
Laszlo
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
edk2-buildtools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
