Revision: 14001
          http://edk2.svn.sourceforge.net/edk2/?rev=14001&view=rev
Author:   jljusten
Date:     2012-12-17 02:12:44 +0000 (Mon, 17 Dec 2012)
Log Message:
-----------
OvmfPkg: fix PIIX4 SUS_TYP value in \_S4 package

The ACPI 5.0 specification says:

  7.3.4.5 System \_S4 State

  [...]
  * DRAM context is not maintained.
  [...]

This corresponds to the following in the PIIX4 spec:

  PMCNTRL -- POWER MANAGEMENT CONTROL REGISTER (IO)
  [...]
  Bits[12:10]  Suspend Type
  [...]
          010  POSCL (Powered On Suspend, Context Lost)

Also, this (ie. decimal 2) is the default suspend type value that qemu
recognizes as an S4 (suspend to disk) request.

Only the value for PM1a_CNT.SLP_TYP is corrected (PM1b_CNT.SLP_TYP is left
at zero), since in OVMF we don't report the optional PM1b_EVT_BLK register
block to OSPM. (PM1b_EVT_BLK is defined as 0 in "Platform.h"; see "4.8.1.1
PM1 Event Registers" in the ACPI 5.0 specification.)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <[email protected]>
Reviewed-by: Jordan Justen <[email protected]>

Modified Paths:
--------------
    trunk/edk2/OvmfPkg/AcpiTables/Dsdt.asl

Modified: trunk/edk2/OvmfPkg/AcpiTables/Dsdt.asl
===================================================================
--- trunk/edk2/OvmfPkg/AcpiTables/Dsdt.asl      2012-12-17 02:12:30 UTC (rev 
14000)
+++ trunk/edk2/OvmfPkg/AcpiTables/Dsdt.asl      2012-12-17 02:12:44 UTC (rev 
14001)
@@ -17,7 +17,7 @@
   // System Sleep States
   //
   Name (\_S0, Package () {5, 0, 0, 0}) // Working
-  Name (\_S4, Package () {1, 0, 0, 0}) // Suspend to Disk
+  Name (\_S4, Package () {2, 0, 0, 0}) // Suspend to Disk (PIIX4: POSCL)
   Name (\_S5, Package () {0, 0, 0, 0}) // Soft Off
 
   //

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to