Revision: 14646
http://sourceforge.net/p/edk2/code/14646
Author: oliviermartin
Date: 2013-09-10 10:10:56 +0000 (Tue, 10 Sep 2013)
Log Message:
-----------
ArmPkg/CpuDxe: Exception Handling SP Adjust
The exception handling support code appears to adjust the stack pointer in the
wrong direction.
It decrements the stack pointer by 0x60, but this should be an increment (add)
for the
downward-growing stack.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen <[email protected]>
Reviewed-by: Olivier Martin <[email protected]>
Modified Paths:
--------------
trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.S
trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.asm
Modified: trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.S
===================================================================
--- trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.S 2013-09-10
08:52:02 UTC (rev 14645)
+++ trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.S 2013-09-10
10:10:56 UTC (rev 14646)
@@ -242,7 +242,7 @@
str R5, [SP, #0x3c] @ Store it in EFI_SYSTEM_CONTEXT_ARM.PC
- sub R1, SP, #0x60 @ We pused 0x60 bytes on the stack
+ add R1, SP, #0x60 @ We pushed 0x60 bytes on the stack
str R1, [SP, #0x34] @ Store it in EFI_SYSTEM_CONTEXT_ARM.SP
@ R0 is ExceptionType
Modified: trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.asm
===================================================================
--- trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.asm 2013-09-10
08:52:02 UTC (rev 14645)
+++ trunk/edk2/ArmPkg/Drivers/CpuDxe/ArmV6/ExceptionSupport.asm 2013-09-10
10:10:56 UTC (rev 14646)
@@ -237,7 +237,7 @@
str R5, [SP, #0x3c] ; Store it in EFI_SYSTEM_CONTEXT_ARM.PC
- sub R1, SP, #0x60 ; We pused 0x60 bytes on the stack
+ add R1, SP, #0x60 ; We pushed 0x60 bytes on the stack
str R1, [SP, #0x34] ; Store it in EFI_SYSTEM_CONTEXT_ARM.SP
; R0 is ExceptionType
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
