On Oct 7, 2013, at 10:31 PM, [email protected] wrote:
> Revision: 14746
> http://sourceforge.net/p/edk2/code/14746
> Author: sfu5
> Date: 2013-10-08 05:31:28 +0000 (Tue, 08 Oct 2013)
> Log Message:
> -----------
> Fix a bug about the ?\226?\128?\156VendorKey?\226?\128?\157 variable update
> logic.
> Signed-off-by: Fu Siyuan <[email protected]>
> Reviewed-by: Ye Ting <[email protected]>
> Reviewed-by: Dong Guo <[email protected]>
>
> Modified Paths:
> --------------
> trunk/edk2/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
>
> Modified:
> trunk/edk2/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
> ===================================================================
> --- trunk/edk2/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
> 2013-10-04 16:34:19 UTC (rev 14745)
> +++ trunk/edk2/SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthService.c
> 2013-10-08 05:31:28 UTC (rev 14746)
> @@ -1089,7 +1089,7 @@
> return Status;
> }
>
> - if (mPlatformMode != SETUP_MODE) {
> + if (mPlatformMode != SETUP_MODE || IsPk) {
Should it not be:
+ if ((mPlatformMode != SETUP_MODE) || IsPk) {
To follow coding standards?
Thanks,
Andrew Fish
> Status = VendorKeyIsModified ();
> }
> } else if (mPlatformMode == USER_MODE) {
>
> This was sent by the SourceForge.net collaborative development platform, the
> world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
> _______________________________________________
> edk2-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-commits
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
