Revision: 14930
          http://sourceforge.net/p/edk2/code/14930
Author:   lzeng14
Date:     2013-12-04 08:19:02 +0000 (Wed, 04 Dec 2013)
Log Message:
-----------
MdeModulePkg: SmmLockBox: remove wrong DepEx

The SmmLockBox driver in
"MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf" currently
specifies a DepEx on EFI_SMM_SW_DISPATCH2_PROTOCOL.

However, the driver doesn't use this protocol at all, either directly or
indirectly. It calls SmiHandlerRegister()
[MdeModulePkg/Core/PiSmmCore/Smi.c] to register SmmLockBoxHandler()
(which serves LockBox requests).

In turn, the SMM Core function SmiHandlerRegister() is also implemented
without EFI_SMM_SW_DISPATCH2_PROTOCOL.

The DepEx has been present since the initial commit of the SmmLockBox
driver (SVN r12029); it is probably superfluous. Let's remove it.

(Alternatively, we could extend OvmfPkg/EmuSmmDxe to fake this protocol,
and return EFI_UNSUPPORTED when any member is called.)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>

Revision Links:
--------------
    http://sourceforge.net/p/edk2/code/12029

Modified Paths:
--------------
    trunk/edk2/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf

Modified: trunk/edk2/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
===================================================================
--- trunk/edk2/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf 
2013-12-04 07:07:10 UTC (rev 14929)
+++ trunk/edk2/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf 
2013-12-04 08:19:02 UTC (rev 14930)
@@ -60,5 +60,4 @@
   gEfiLockBoxProtocolGuid            ## PRODUCED
 
 [Depex]
-  gEfiSmmSwDispatch2ProtocolGuid
-
+  TRUE

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to