Revision: 15016
http://sourceforge.net/p/edk2/code/15016
Author: lzeng14
Date: 2013-12-23 06:41:36 +0000 (Mon, 23 Dec 2013)
Log Message:
-----------
MdePkg PcdLib: Follow the comment of LibPcdGetNextToken to ASSERT when an
invalid TokenNumber input.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <[email protected]>
Reviewed by: Liming Gao <[email protected]>
Modified Paths:
--------------
trunk/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.c
trunk/edk2/MdePkg/Library/PeiPcdLib/PeiPcdLib.c
Modified: trunk/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.c
===================================================================
--- trunk/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.c 2013-12-23 06:33:12 UTC
(rev 15015)
+++ trunk/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.c 2013-12-23 06:41:36 UTC
(rev 15016)
@@ -1002,8 +1002,11 @@
IN UINTN TokenNumber
)
{
- GetPiPcdProtocol()->GetNextToken (Guid, &TokenNumber);
+ EFI_STATUS Status;
+ Status = GetPiPcdProtocol()->GetNextToken (Guid, &TokenNumber);
+ ASSERT (!EFI_ERROR (Status) || TokenNumber == 0);
+
return TokenNumber;
}
Modified: trunk/edk2/MdePkg/Library/PeiPcdLib/PeiPcdLib.c
===================================================================
--- trunk/edk2/MdePkg/Library/PeiPcdLib/PeiPcdLib.c 2013-12-23 06:33:12 UTC
(rev 15015)
+++ trunk/edk2/MdePkg/Library/PeiPcdLib/PeiPcdLib.c 2013-12-23 06:41:36 UTC
(rev 15016)
@@ -1010,8 +1010,11 @@
IN UINTN TokenNumber
)
{
- (GetPiPcdPpiPointer ())->GetNextToken (Guid, &TokenNumber);
+ EFI_STATUS Status;
+ Status = (GetPiPcdPpiPointer ())->GetNextToken (Guid, &TokenNumber);
+ ASSERT (!EFI_ERROR (Status) || TokenNumber == 0);
+
return TokenNumber;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
