Revision: 15796
          http://sourceforge.net/p/edk2/code/15796
Author:   lgao4
Date:     2014-08-13 08:39:54 +0000 (Wed, 13 Aug 2014)
Log Message:
-----------
Add the missing parameter comments for BaseSerialPortLib16550 lib. MdePkg: Fix 
Clang build failure

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gao, Liming <[email protected]>

Modified Paths:
--------------
    trunk/edk2/MdeModulePkg/Include/Ppi/SerialPortPei.h
    
trunk/edk2/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c

Modified: trunk/edk2/MdeModulePkg/Include/Ppi/SerialPortPei.h
===================================================================
--- trunk/edk2/MdeModulePkg/Include/Ppi/SerialPortPei.h 2014-08-13 06:31:08 UTC 
(rev 15795)
+++ trunk/edk2/MdeModulePkg/Include/Ppi/SerialPortPei.h 2014-08-13 08:39:54 UTC 
(rev 15796)
@@ -13,8 +13,8 @@
 
 **/
 
-#ifndef _PEI_SERIAL_PORT_PPI_H
-#define _PEI_SERIAL_PORT_PPI_H
+#ifndef __PEI_SERIAL_PORT_PPI_H__
+#define __PEI_SERIAL_PORT_PPI_H__
 
 #define PEI_SERIAL_PORT_PPI \
   { \

Modified: 
trunk/edk2/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c
===================================================================
--- 
trunk/edk2/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c 
    2014-08-13 06:31:08 UTC (rev 15795)
+++ 
trunk/edk2/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c 
    2014-08-13 08:39:54 UTC (rev 15796)
@@ -63,6 +63,7 @@
   parameter Offset is added to the base address of the 16550 registers that is 
specified 
   by PcdSerialRegisterBase. 
   
+  @param  Base    The base address register of UART device.
   @param  Offset  The offset of the 16550 register to read.
 
   @return The value read from the 16550 register.
@@ -87,6 +88,7 @@
   parameter Offset is added to the base address of the 16550 registers that is 
specified 
   by PcdSerialRegisterBase. 
   
+  @param  Base    The base address register of UART device.
   @param  Offset  The offset of the 16550 register to write.
   @param  Value   The value to write to the 16550 register specified by Offset.
 
@@ -173,7 +175,7 @@
   This function assumes Root Bus Numer is Zero, and enables I/O and MMIO in 
PCI UART 
   Device if they are not already enabled. 
   
-  @return  The base address register of the PCI UART device.
+  @return  The base address register of the UART device.
 
 **/
 UINTN
@@ -411,6 +413,8 @@
 /**
   Return whether the hardware flow control signal allows writing.
 
+  @param  SerialRegisterBase The base address register of UART device.
+
   @retval TRUE  The serial port is writable.
   @retval FALSE The serial port is not writable.
 **/

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to