Revision: 15815
http://sourceforge.net/p/edk2/code/15815
Author: shenshushi
Date: 2014-08-18 00:48:22 +0000 (Mon, 18 Aug 2014)
Log Message:
-----------
ShellPkg: Fix comments. Refine code style.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <[email protected]>
Reviewed-by: Jaben Carsey <[email protected]>
Modified Paths:
--------------
trunk/edk2/ShellPkg/Application/Shell/ShellProtocol.c
trunk/edk2/ShellPkg/Include/Protocol/EfiShell.h
trunk/edk2/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
trunk/edk2/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
trunk/edk2/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
Modified: trunk/edk2/ShellPkg/Application/Shell/ShellProtocol.c
===================================================================
--- trunk/edk2/ShellPkg/Application/Shell/ShellProtocol.c 2014-08-16
16:19:11 UTC (rev 15814)
+++ trunk/edk2/ShellPkg/Application/Shell/ShellProtocol.c 2014-08-18
00:48:22 UTC (rev 15815)
@@ -2054,7 +2054,7 @@
}
SHELL_FREE_NON_NULL(BasePath);
return(Status);
- }
+}
/**
Get the GUID value from a human readable name.
@@ -2586,8 +2586,8 @@
multiple environment variables are being
returned, Attributes
is undefined.
- @retval NULL The environment variable doesn\x92t exist.
- @return A non-NULL value points to the variable\x92s
value. The returned
+ @retval NULL The environment variable doesn't exist.
+ @return A non-NULL value points to the variable's
value. The returned
pointer does not need to be freed by the
caller.
**/
CONST CHAR16 *
Modified: trunk/edk2/ShellPkg/Include/Protocol/EfiShell.h
===================================================================
--- trunk/edk2/ShellPkg/Include/Protocol/EfiShell.h 2014-08-16 16:19:11 UTC
(rev 15814)
+++ trunk/edk2/ShellPkg/Include/Protocol/EfiShell.h 2014-08-18 00:48:22 UTC
(rev 15815)
@@ -431,8 +431,8 @@
multiple environment variables are being
returned, Attributes
is undefined.
- @retval NULL The environment variable doesn\x92t exist.
- @return The environment variable\x92s value. The
returned pointer does not
+ @retval NULL The environment variable doesn't exist.
+ @return The environment variable's value. The returned
pointer does not
need to be freed by the caller.
**/
typedef
Modified:
trunk/edk2/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
===================================================================
--- trunk/edk2/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
2014-08-16 16:19:11 UTC (rev 15814)
+++ trunk/edk2/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
2014-08-18 00:48:22 UTC (rev 15815)
@@ -820,8 +820,8 @@
Function to add a new GUID/Name mapping.
@param[in] Guid The Guid
-@param[in] NameId The STRING id of the HII string to use
-@param[in] Dump The pointer to the dump function
+@param[in] NameID The STRING id of the HII string to use
+@param[in] DumpFunc The pointer to the dump function
@retval EFI_SUCCESS The operation was sucessful
Modified: trunk/edk2/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
===================================================================
--- trunk/edk2/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
2014-08-16 16:19:11 UTC (rev 15814)
+++ trunk/edk2/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
2014-08-18 00:48:22 UTC (rev 15815)
@@ -215,7 +215,7 @@
}
/**
- Find a dynamic command protocol instance given a command name string
+ Find a dynamic command protocol instance given a command name string.
@param CommandString the command name string
@@ -277,7 +277,7 @@
IN CONST CHAR16 *CommandString
)
{
- return (ShellCommandFindDynamicCommand(CommandString) != NULL);
+ return (BOOLEAN) ((ShellCommandFindDynamicCommand(CommandString) != NULL));
}
/**
Modified: trunk/edk2/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
===================================================================
--- trunk/edk2/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
2014-08-16 16:19:11 UTC (rev 15814)
+++ trunk/edk2/ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
2014-08-18 00:48:22 UTC (rev 15815)
@@ -35,11 +35,15 @@
)
{
EFI_STATUS Status;
- BOOLEAN Found = FALSE;
- EFI_HANDLE *CommandHandleList = NULL;
+ BOOLEAN Found;
+ EFI_HANDLE *CommandHandleList;
EFI_HANDLE *NextCommand;
EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL *DynamicCommand;
- CHAR16 *OutText = NULL;
+ CHAR16 *OutText;
+
+ Found = FALSE;
+ CommandHandleList = NULL;
+ OutText = NULL;
CommandHandleList =
GetHandleListByProtocol(&gEfiShellDynamicCommandProtocolGuid);
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
