I made an error here. Erik Bjorge, not Eric Dong submitted the review. > -----Original Message----- > From: [email protected] > [mailto:[email protected]] > Sent: Tuesday, August 19, 2014 1:58 PM > To: [email protected] > Subject: SF.net SVN: edk2:[15838] trunk/edk2/ShellPkg/Library/UefiShellLib/ > UefiShellLib.c > > Revision: 15838 > http://sourceforge.net/p/edk2/code/15838 > Author: jcarsey > Date: 2014-08-19 20:58:03 +0000 (Tue, 19 Aug 2014) > Log Message: > ----------- > ShellPkg: Check while string up to space, not the character > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jaben Carsey <[email protected]> > Reviewed-by: Eric Dong <[email protected]> > > Modified Paths: > -------------- > trunk/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > Modified: trunk/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.c > ========================================================== > ========= > --- trunk/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.c 2014-08-19 > 13:36:36 UTC (rev 15837) > +++ trunk/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.c 2014-08-19 > 20:58:03 UTC (rev 15838) > @@ -1903,7 +1903,7 @@ > // > // If we accept numbers then dont return TRUE. (they will be values) > // > - if (((Name[0] == L'-' || Name[0] == L'+') && > ShellIsHexaDecimalDigitCharacter(Name[1])) && AlwaysAllowNumbers) { > + if (((Name[0] == L'-' || Name[0] == L'+') && > InternalShellIsHexOrDecimalNumber(Name+1, FALSE, FALSE)) && > AlwaysAllowNumbers) { > return (FALSE); > } > > > This was sent by the SourceForge.net collaborative development platform, > the world's largest Open Source development site. > > > ------------------------------------------------------------------------------ > _______________________________________________ > edk2-commits mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-commits
------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ edk2-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-commits
