Revision: 15904
          http://sourceforge.net/p/edk2/code/15904
Author:   oliviermartin
Date:     2014-08-26 10:17:05 +0000 (Tue, 26 Aug 2014)
Log Message:
-----------
ArmPlatformPkg/Bds: Fix compiler warning

- Fix RVCT warning: 'SecondEntry' may be uninitialised.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Harry Liebel <[email protected]>
Reviewed-By: Olivier Martin <[email protected]>

Modified Paths:
--------------
    trunk/edk2/ArmPlatformPkg/Bds/BootMenu.c

Modified: trunk/edk2/ArmPlatformPkg/Bds/BootMenu.c
===================================================================
--- trunk/edk2/ArmPlatformPkg/Bds/BootMenu.c    2014-08-26 10:16:16 UTC (rev 
15903)
+++ trunk/edk2/ArmPlatformPkg/Bds/BootMenu.c    2014-08-26 10:17:05 UTC (rev 
15904)
@@ -691,6 +691,7 @@
     }
 
     SelectedEntry = &BootOptionEntry->Link;
+    SecondEntry = NULL;
     // Note down the previous entry in the list to be able to cancel changes
     PrevEntry = GetPreviousNode (BootOptionsList, SelectedEntry);
 
@@ -739,7 +740,9 @@
       } while ((!Move) && (!Save) && (!Cancel));
 
       if (Move) {
-        SwapListEntries (SelectedEntry, SecondEntry);
+        if ((SelectedEntry != NULL) && (SecondEntry != NULL)) {
+          SwapListEntries (SelectedEntry, SecondEntry);
+        }
       } else {
         if (Save) {
           Status = GetGlobalEnvironmentVariable (

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to