Revision: 16167
          http://sourceforge.net/p/edk2/code/16167
Author:   tye1
Date:     2014-09-24 09:35:32 +0000 (Wed, 24 Sep 2014)
Log Message:
-----------
Enhance TargetName check when save iSCSI configuration.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ye Ting  <[email protected]>
Reviewed-by: Wu, Jiaxin <[email protected]>
Reviewed-by: Fu, Siyuan <[email protected]>

Modified Paths:
--------------
    trunk/edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c

Modified: trunk/edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
===================================================================
--- trunk/edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c    
2014-09-24 07:49:20 UTC (rev 16166)
+++ trunk/edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c    
2014-09-24 09:35:32 UTC (rev 16167)
@@ -872,6 +872,23 @@
             Status = EFI_INVALID_PARAMETER;
             break;
           }
+
+          //
+          // Validate iSCSI target name configuration again:
+          // The format of iSCSI target name is already verified when user 
input the name;
+          // here we only check the case user does not input the name.
+          //
+          if (Private->Current->SessionConfigData.TargetName[0] == '\0') {
+            CreatePopUp (
+              EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
+              &Key,
+              L"iSCSI target name is NULL!",
+              NULL
+              );
+            Status = EFI_INVALID_PARAMETER;
+            break;
+          }
+
         }
 
         if (IfrNvData->CHAPType != ISCSI_CHAP_NONE) {


------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to