Revision: 16450
http://sourceforge.net/p/edk2/code/16450
Author: erictian
Date: 2014-11-27 01:01:43 +0000 (Thu, 27 Nov 2014)
Log Message:
-----------
MdeModulePkg: Misc comments and DEBUG messages
Fixed some spelling typos in some comments. Added a couple of useful DEBUG
messages
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud <[email protected]>
Reviewed-by: Feng Tian <[email protected]>
Modified Paths:
--------------
trunk/edk2/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
trunk/edk2/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c
trunk/edk2/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
trunk/edk2/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
Modified: trunk/edk2/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c
===================================================================
--- trunk/edk2/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c 2014-11-26 08:21:54 UTC
(rev 16449)
+++ trunk/edk2/MdeModulePkg/Bus/I2c/I2cDxe/I2cHost.c 2014-11-27 01:01:43 UTC
(rev 16450)
@@ -2,6 +2,7 @@
This file implements I2C Host Protocol which provides callers with the
ability to
do I/O transactions to all of the devices on the I2C bus.
+ Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2013 - 2014, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD
License
@@ -672,6 +673,10 @@
I2cHostContext->I2cEvent,
&I2cHostContext->Status
);
+
+ if (EFI_ERROR (Status)) {
+ DEBUG((DEBUG_ERROR, "I2cHostI2cBusConfigurationAvailable: Error starting
I2C operation, %r\n", Status));
+ }
}
/**
Modified: trunk/edk2/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c
===================================================================
--- trunk/edk2/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c 2014-11-26 08:21:54 UTC
(rev 16449)
+++ trunk/edk2/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c 2014-11-27 01:01:43 UTC
(rev 16450)
@@ -519,7 +519,7 @@
// terminate the transfer
//
if (!IsLow && (TdHw->ShortPacket == 1) && (Len < Td->DataLen)) {
- DEBUG ((EFI_D_INFO, "UhciCheckTdStatus: short packet read occured\n"));
+ DEBUG ((EFI_D_VERBOSE, "UhciCheckTdStatus: short packet read
occured\n"));
Finished = TRUE;
goto ON_EXIT;
Modified: trunk/edk2/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
===================================================================
--- trunk/edk2/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c 2014-11-26 08:21:54 UTC
(rev 16449)
+++ trunk/edk2/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c 2014-11-27 01:01:43 UTC
(rev 16450)
@@ -257,7 +257,7 @@
//
{ TRUE, FALSE, &gEfiSmmConfigurationProtocolGuid,
SmmIplSmmConfigurationEventNotify, &gEfiSmmConfigurationProtocolGuid,
TPL_NOTIFY, NULL },
//
- // Declare protocl notification on DxeSmmReadyToLock protocols. When this
notification is etablished,
+ // Declare protocol notification on DxeSmmReadyToLock protocols. When this
notification is established,
// the associated event is immediately signalled, so the notification
function will be executed and the
// DXE SMM Ready To Lock Protocol will be found if it is already in the
handle database.
//
@@ -659,7 +659,7 @@
/**
Event notification that is fired every time a DxeSmmReadyToLock protocol is
added
- or if gEfiEventReadyToBootGuid is signalled.
+ or if gEfiEventReadyToBootGuid is signaled.
@param Event The Event that is being processed, not used.
@param Context Event Context, not used.
@@ -694,7 +694,7 @@
} else {
//
// If SMM is not locked yet and we got here from gEfiEventReadyToBootGuid
being
- // signalled, then gEfiDxeSmmReadyToLockProtocolGuid was not installed as
expected.
+ // signaled, then gEfiDxeSmmReadyToLockProtocolGuid was not installed as
expected.
// Print a warning on debug builds.
//
DEBUG ((DEBUG_WARN, "SMM IPL! DXE SMM Ready To Lock Protocol not
installed before Ready To Boot signal\n"));
Modified: trunk/edk2/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
===================================================================
--- trunk/edk2/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c 2014-11-26
08:21:54 UTC (rev 16449)
+++ trunk/edk2/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c 2014-11-27
01:01:43 UTC (rev 16450)
@@ -11,6 +11,7 @@
always on the first sector of a media. The first sector also contains
the legacy boot strap code.
+Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR>
Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD
License
@@ -74,6 +75,9 @@
// return FALSE since no block devices on a system are implemented
// with INT 13h
//
+
+ DEBUG((EFI_D_INFO, "PartitionValidMbr: Bad MBR partition size
EndingLBA(%1x) > LastLBA(%1x)\n", EndingLBA, LastLba));
+
return FALSE;
}
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits