Revision: 17108
http://sourceforge.net/p/edk2/code/17108
Author: oliviermartin
Date: 2015-04-02 13:51:28 +0000 (Thu, 02 Apr 2015)
Log Message:
-----------
ArmPkg/BaseMemoryLib(Sym|Vstm): Do not post increment returned pointer
InternalMemScanMem(8|16|32|64) was returning a pointer that was
post incremented from the expected returned value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <[email protected]>
Reviewed-by: Ronald Cron <[email protected]>
Modified Paths:
--------------
trunk/edk2/ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c
trunk/edk2/ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c
Modified: trunk/edk2/ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c
===================================================================
--- trunk/edk2/ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c 2015-04-02
13:50:18 UTC (rev 17107)
+++ trunk/edk2/ArmPkg/Library/BaseMemoryLibStm/MemLibGeneric.c 2015-04-02
13:51:28 UTC (rev 17108)
@@ -162,9 +162,10 @@
Pointer = (CONST UINT8*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
@@ -192,9 +193,10 @@
Pointer = (CONST UINT16*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
@@ -222,9 +224,10 @@
Pointer = (CONST UINT32*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
@@ -252,9 +255,10 @@
Pointer = (CONST UINT64*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
Modified: trunk/edk2/ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c
===================================================================
--- trunk/edk2/ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c 2015-04-02
13:50:18 UTC (rev 17107)
+++ trunk/edk2/ArmPkg/Library/BaseMemoryLibVstm/MemLibGeneric.c 2015-04-02
13:51:28 UTC (rev 17108)
@@ -162,9 +162,10 @@
Pointer = (CONST UINT8*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
@@ -192,9 +193,10 @@
Pointer = (CONST UINT16*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
@@ -222,9 +224,10 @@
Pointer = (CONST UINT32*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
@@ -252,9 +255,10 @@
Pointer = (CONST UINT64*)Buffer;
do {
- if (*(Pointer++) == Value) {
+ if (*Pointer == Value) {
return Pointer;
}
+ Pointer++;
} while (--Length != 0);
return NULL;
}
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
