Revision: 18205
http://sourceforge.net/p/edk2/code/18205
Author: shenshushi
Date: 2015-08-12 01:27:31 +0000 (Wed, 12 Aug 2015)
Log Message:
-----------
BaseTools/GenFds: Fix 'NoneType' object is not iterable error.
When adding section VERSION in FDF file, for example:
FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) {
SECTION RAW = MdeModulePkg/Logo/Logo.bmp
SECTION UI = "Logo"
SECTION VERSION = "0001"
}
GenFds will report the following error:
Traceback (most recent call last):
File "GenFds.py", line 276, in main
File "GenFds.py", line 391, in GenFd
File "Fd.py", line 93, in GenFd
File "Region.py", line 106, in AddToBuffer
File "Fv.py", line 114, in AddToBuffer
File "FfsFileStatement.py", line 117, in GenFfs
File "VerSection.py", line 80, in GenSection
File "GenFdsGlobalVariable.py", line 401, in GenerateSection
TypeError: 'NoneType' object is not iterable.
We found in GenFdsGlobalVariable.py line 401 'list' requires a iteralbe object
as parameter while the 'Input' is None.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <[email protected]>
Reviewed-by: Yingke Liu <[email protected]>
Reviewed-by: Liming Gao <[email protected]>
Modified Paths:
--------------
trunk/edk2/BaseTools/Source/Python/GenFds/VerSection.py
Modified: trunk/edk2/BaseTools/Source/Python/GenFds/VerSection.py
===================================================================
--- trunk/edk2/BaseTools/Source/Python/GenFds/VerSection.py 2015-08-11
12:32:53 UTC (rev 18204)
+++ trunk/edk2/BaseTools/Source/Python/GenFds/VerSection.py 2015-08-12
01:27:31 UTC (rev 18205)
@@ -1,7 +1,7 @@
## @file
# process Version section generation
#
-# Copyright (c) 2007 - 2014, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD
License
@@ -76,7 +76,7 @@
else:
StringData = ''
- GenFdsGlobalVariable.GenerateSection(OutputFile, None,
'EFI_SECTION_VERSION',
+ GenFdsGlobalVariable.GenerateSection(OutputFile, [],
'EFI_SECTION_VERSION',
Ver=StringData,
BuildNumber=self.BuildNum)
OutputFileList = []
OutputFileList.append(OutputFile)
------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits