Revision: 18222
          http://sourceforge.net/p/edk2/code/18222
Author:   shenshushi
Date:     2015-08-14 07:20:09 +0000 (Fri, 14 Aug 2015)
Log Message:
-----------
ShellPkg\Tftp.c: Refine parameter name and use implicit comparison for BOOLEAN 
variable.

1. Refine parameter name to consistent with function headers.
2. To avoid potential bug BOOLEAN values should not use explicit comparisons to 
TRUE or FALSE.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <[email protected]>
Reviewed-by: Ruiyu Ni <[email protected]>

Modified Paths:
--------------
    trunk/edk2/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c

Modified: trunk/edk2/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
===================================================================
--- trunk/edk2/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c  2015-08-14 
06:22:10 UTC (rev 18221)
+++ trunk/edk2/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c  2015-08-14 
07:20:09 UTC (rev 18222)
@@ -73,7 +73,7 @@
 EFI_STATUS 
 GetNicName (
   IN   EFI_HANDLE  ControllerHandle,
-  IN   UINTN       Index,
+  IN   UINTN       NicNumber,
   OUT  CHAR16      *NicName
   );
 
@@ -524,7 +524,7 @@
       );
   }
 
-  if ((UserNicName != NULL) && (NicFound == FALSE)) {
+  if ((UserNicName != NULL) && (!NicFound)) {
     ShellPrintHiiEx (
       -1, -1, NULL, STRING_TOKEN (STR_TFTP_ERR_NIC_NOT_FOUND),
       gShellTftpHiiHandle, UserNicName


------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to