Revision: 18819
          http://sourceforge.net/p/edk2/code/18819
Author:   vanjeff
Date:     2015-11-16 08:18:01 +0000 (Mon, 16 Nov 2015)
Log Message:
-----------
NetworkPkg: HttpDxe sometimes free a pointer twice

In EfiHttpRequest, HostName was getting freed twice whenever
HttpTransmitTcp4 failed. Moved FreePool (HostName) after
HttpTransmitTcp4 call to avoid a double free.

(Sync patch r18709 from main trunk.)

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Nagaraj Hegde <[email protected]>
Reviewed-by: Samer El-Haj-Mahmoud <[email protected]>
Reviewed-by: Ye Ting <[email protected]>

Revision Links:
--------------
    http://sourceforge.net/p/edk2/code/18709

Modified Paths:
--------------
    branches/UDK2015/NetworkPkg/HttpDxe/HttpImpl.c

Modified: branches/UDK2015/NetworkPkg/HttpDxe/HttpImpl.c
===================================================================
--- branches/UDK2015/NetworkPkg/HttpDxe/HttpImpl.c      2015-11-16 08:17:16 UTC 
(rev 18818)
+++ branches/UDK2015/NetworkPkg/HttpDxe/HttpImpl.c      2015-11-16 08:18:01 UTC 
(rev 18819)
@@ -486,10 +486,6 @@
     goto Error4;
   }
 
-  if (HostName != NULL) {
-    FreePool (HostName);
-  }
-
   //
   // Transmit the request message.
   //
@@ -505,6 +501,10 @@
 
   DispatchDpc ();
 
+  if (HostName != NULL) {
+    FreePool (HostName);
+  }
+
   return EFI_SUCCESS;
 
 Error5:


------------------------------------------------------------------------------
Presto, an open source distributed SQL query engine for big data, initially
developed by Facebook, enables you to easily query your data on Hadoop in a 
more interactive manner. Teradata is also now providing full enterprise
support for Presto. Download a free open source copy now.
http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to