Revision: 18887
http://sourceforge.net/p/edk2/code/18887
Author: lzeng14
Date: 2015-11-18 10:13:31 +0000 (Wed, 18 Nov 2015)
Log Message:
-----------
MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call
The ASSERT (PrivateData->PeiMemoryInstalled) in if
(PrivateData->PeiMemoryInstalled)
condition is useless, it should be ASSERT (FALSE) to follow the code's
expectation.
Cc: Liming Gao <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <[email protected]>
Reviewed-by: Liming Gao <[email protected]>
Modified Paths:
--------------
trunk/edk2/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
Modified: trunk/edk2/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
===================================================================
--- trunk/edk2/MdeModulePkg/Core/Pei/Memory/MemoryServices.c 2015-11-18
08:56:57 UTC (rev 18886)
+++ trunk/edk2/MdeModulePkg/Core/Pei/Memory/MemoryServices.c 2015-11-18
10:13:31 UTC (rev 18887)
@@ -96,7 +96,7 @@
//
if (PrivateData->PeiMemoryInstalled) {
DEBUG ((EFI_D_ERROR, "ERROR: PeiInstallPeiMemory is called more than
once!\n"));
- ASSERT (PrivateData->PeiMemoryInstalled);
+ ASSERT (FALSE);
return EFI_SUCCESS;
}
------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
