Revision: 19240
http://sourceforge.net/p/edk2/code/19240
Author: abiesheuvel
Date: 2015-12-14 13:00:03 +0000 (Mon, 14 Dec 2015)
Log Message:
-----------
ArmPlatformPkg/ArmJunoLib: use declared PPI rather than module local var
We can refer to gArmMpCoreInfoPpiGuid directly if we declare it under
[Ppis] in the library's .inf so there is no need to copy it into a
module local variable.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <[email protected]>
Reviewed-by: Leif Lindholm <[email protected]>
Modified Paths:
--------------
trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJuno.c
trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJunoLib.inf
Modified: trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJuno.c
===================================================================
--- trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJuno.c
2015-12-14 12:59:52 UTC (rev 19239)
+++ trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJuno.c
2015-12-14 13:00:03 UTC (rev 19240)
@@ -140,14 +140,12 @@
return EFI_SUCCESS;
}
-// Needs to be declared in the file. Otherwise gArmMpCoreInfoPpiGuid is
undefined in the contect of PrePeiCore
-EFI_GUID mArmMpCoreInfoPpiGuid = ARM_MP_CORE_INFO_PPI_GUID;
ARM_MP_CORE_INFO_PPI mMpCoreInfoPpi = { PrePeiCoreGetMpCoreInfo };
EFI_PEI_PPI_DESCRIPTOR gPlatformPpiTable[] = {
{
EFI_PEI_PPI_DESCRIPTOR_PPI,
- &mArmMpCoreInfoPpiGuid,
+ &gArmMpCoreInfoPpiGuid,
&mMpCoreInfoPpi
}
};
Modified: trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJunoLib.inf
===================================================================
--- trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJunoLib.inf
2015-12-14 12:59:52 UTC (rev 19239)
+++ trunk/edk2/ArmPlatformPkg/ArmJunoPkg/Library/ArmJunoLib/ArmJunoLib.inf
2015-12-14 13:00:03 UTC (rev 19240)
@@ -62,3 +62,6 @@
gArmPlatformTokenSpaceGuid.PcdPciMmio32Size
gArmPlatformTokenSpaceGuid.PcdPciMmio64Base
gArmPlatformTokenSpaceGuid.PcdPciMmio64Size
+
+[Ppis]
+ gArmMpCoreInfoPpiGuid
------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
