Revision: 19357
          http://sourceforge.net/p/edk2/code/19357
Author:   vanjeff
Date:     2015-12-18 05:46:37 +0000 (Fri, 18 Dec 2015)
Log Message:
-----------
UefiCpuPkg/CpuMpPei: Fix pack(1) issue on x64 arch

Packing alignment for MP_CPU_EXCHANGE_INFO should be 1. This should be typo when
check-in CpuMpPei driver. IA32 arch MP_CPU_EXCHANGE_INFO is luckly pack(1). It
leads CpuMpPei x64 version hung.

(Sync patch r19340 from main trunk.)

Contributed-under: TianoCore Contribution Agreement 1.0
Reported-by: Michael Kinney <[email protected]>
Cc: Feng Tian <[email protected]>
Cc: Michael Kinney <[email protected]>
Cc: Jordan Justen <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <[email protected]>
Tested-by: Michael Kinney <[email protected]>
Reviewed-by: Michael Kinney <[email protected]>

Revision Links:
--------------
    http://sourceforge.net/p/edk2/code/19340

Modified Paths:
--------------
    branches/UDK2015/UefiCpuPkg/CpuMpPei/CpuMpPei.h

Modified: branches/UDK2015/UefiCpuPkg/CpuMpPei/CpuMpPei.h
===================================================================
--- branches/UDK2015/UefiCpuPkg/CpuMpPei/CpuMpPei.h     2015-12-18 05:45:52 UTC 
(rev 19356)
+++ branches/UDK2015/UefiCpuPkg/CpuMpPei/CpuMpPei.h     2015-12-18 05:46:37 UTC 
(rev 19357)
@@ -72,7 +72,7 @@
 
 typedef struct _PEI_CPU_MP_DATA  PEI_CPU_MP_DATA;
 
-#pragma pack()
+#pragma pack(1)
 
 typedef union {
   struct {
@@ -95,6 +95,8 @@
 
 //
 // MP CPU exchange information for AP reset code
+// This structure is required to be packed because fixed field offsets
+// into this structure are used in assembly code in this module
 //
 typedef struct {
   UINTN                 Lock;


------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to