Revision: 19574
http://sourceforge.net/p/edk2/code/19574
Author: lzeng14
Date: 2015-12-29 09:07:32 +0000 (Tue, 29 Dec 2015)
Log Message:
-----------
SecurityPkg AuthVariableLib: Correct comment/error log about CleanCertsFromDb
Cc: Chao Zhang <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <[email protected]>
Reviewed-by: Chao Zhang <[email protected]>
Modified Paths:
--------------
trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthService.c
trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c
Modified: trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthService.c
===================================================================
--- trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthService.c
2015-12-29 09:04:55 UTC (rev 19573)
+++ trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthService.c
2015-12-29 09:07:32 UTC (rev 19574)
@@ -2984,13 +2984,14 @@
/**
Clean up signer's certificates for common authenticated variable
by corresponding VariableName and VendorGuid from "certdb".
- Sytem may break down during Timebased Variable update & certdb update,
- make them inconsistent, this function is called in AuthVariable Init to
ensure
- consistency
-
- @retval EFI_NOT_FOUND Fail to find matching certs.
- @retval EFI_SUCCESS Find matching certs and output parameters.
+ System may break down during Timebased Variable update & certdb update,
+ make them inconsistent, this function is called in AuthVariable Init
+ to ensure consistency.
+ @retval EFI_NOT_FOUND Fail to find variable "certdb".
+ @retval EFI_OUT_OF_RESOURCES The operation is failed due to lack of
resources.
+ @retval EFI_SUCCESS The operation is completed successfully.
+
**/
EFI_STATUS
CleanCertsFromDb (
@@ -3040,9 +3041,6 @@
while (Offset < (UINT32) DataSize) {
Ptr = (AUTH_CERT_DB_DATA *) (Data + Offset);
- //
- // Check whether VendorGuid matches.
- //
NodeSize = ReadUnaligned32 (&Ptr->CertNodeSize);
NameSize = ReadUnaligned32 (&Ptr->NameSize);
Modified: trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c
===================================================================
--- trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c
2015-12-29 09:04:55 UTC (rev 19573)
+++ trunk/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c
2015-12-29 09:07:32 UTC (rev 19574)
@@ -283,7 +283,7 @@
//
Status = CleanCertsFromDb();
if (EFI_ERROR (Status)) {
- DEBUG ((EFI_D_INFO, "Clean up CertDB fail! Status %x\n", Status));
+ DEBUG ((EFI_D_ERROR, "Clean up CertDB fail! Status %x\n", Status));
return Status;
}
}
------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
