Revision: 19697
          http://sourceforge.net/p/edk2/code/19697
Author:   yzhu52
Date:     2016-01-20 05:15:55 +0000 (Wed, 20 Jan 2016)
Log Message:
-----------
BaseTools: Improve LzmaF86Compress wrapper

- Remove test usage declared obsolescent by POSIX
- Pass argv array through as literal rather than forming into a string, then
  string-splitting and glob-expanding same.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Charles Duffy <[email protected]>
Reviewed-by: Yonghong Zhu <[email protected]>

Modified Paths:
--------------
    trunk/edk2/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress
    trunk/edk2/BaseTools/BinWrappers/PosixLike/LzmaF86Compress

Modified: trunk/edk2/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress
===================================================================
--- trunk/edk2/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress 2016-01-20 
05:14:10 UTC (rev 19696)
+++ trunk/edk2/BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress 2016-01-20 
05:15:55 UTC (rev 19697)
@@ -12,11 +12,12 @@
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
 
-for arg in $*; do
-  if [ "arg" = "-e" -o "arg" = "-d" ]; then
-    FLAG=--f86
-    break;
-  fi
-done
+for arg; do
+  case $arg in
+    -e|-d)
+      set -- "$@" --f86
+      break
+    ;;
+esac
 
-LzmaCompress $* $FLAG
+exec LzmaCompress "$@"

Modified: trunk/edk2/BaseTools/BinWrappers/PosixLike/LzmaF86Compress
===================================================================
--- trunk/edk2/BaseTools/BinWrappers/PosixLike/LzmaF86Compress  2016-01-20 
05:14:10 UTC (rev 19696)
+++ trunk/edk2/BaseTools/BinWrappers/PosixLike/LzmaF86Compress  2016-01-20 
05:15:55 UTC (rev 19697)
@@ -12,11 +12,12 @@
 # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #
 
-for arg in $*; do
-  if [ "$arg" = "-e" -o "$arg" = "-d" ]; then
-    FLAG=--f86
-    break;
-  fi
-done
+for arg; do
+  case $arg in
+    -e|-d)
+      set -- "$@" --f86
+      break
+    ;;
+esac
 
-LzmaCompress $* $FLAG
+exec LzmaCompress "$@"


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to