Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 0ccc97e9c858cac2b64e0ecd18352af255669e16
      
https://github.com/tianocore/edk2/commit/0ccc97e9c858cac2b64e0ecd18352af255669e16
  Author: Laszlo Ersek <ler...@redhat.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M OvmfPkg/QemuVideoDxe/Initialize.c
    M OvmfPkg/QemuVideoDxe/Qemu.h

  Log Message:
  -----------
  OvmfPkg/QemuVideoDxe: drop useless QEMU_VIDEO_MODE_DATA.RefreshRate

This field is never used beyond assignment and debug-logging. Remove it.

Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>


  Commit: 9ebb7ce8dda515fa387dda44e998ceb123137c26
      
https://github.com/tianocore/edk2/commit/9ebb7ce8dda515fa387dda44e998ceb123137c26
  Author: Laszlo Ersek <ler...@redhat.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M OvmfPkg/QemuVideoDxe/Initialize.c
    M OvmfPkg/QemuVideoDxe/Qemu.h

  Log Message:
  -----------
  OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_CIRRUS_MODES.RefreshRate

Thanks to the previous patch, this field is also unnecessary now. Remove
it.

The patch is best reviewed with "git show --word-diff".

Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>


  Commit: 37b9c0a656ea446bad1824b70a48905e5be1a37b
      
https://github.com/tianocore/edk2/commit/37b9c0a656ea446bad1824b70a48905e5be1a37b
  Author: Laszlo Ersek <ler...@redhat.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M OvmfPkg/QemuVideoDxe/Qemu.h

  Log Message:
  -----------
  OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.CurrentMode

This field is never used.

Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>


  Commit: 88ba362da776b8971db792e32cd21d5c6233d931
      
https://github.com/tianocore/edk2/commit/88ba362da776b8971db792e32cd21d5c6233d931
  Author: Laszlo Ersek <ler...@redhat.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M OvmfPkg/QemuVideoDxe/Gop.c
    M OvmfPkg/QemuVideoDxe/Qemu.h

  Log Message:
  -----------
  OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.LineBuffer

This field is (re)allocated in QemuVideoGraphicsOutputSetMode(), released
in QemuVideoGraphicsOutputDestructor(), and used for nothing else. Remove
it.

Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>


  Commit: 4dd8787a20e2b74cfcc297253f237e0ac86c9289
      
https://github.com/tianocore/edk2/commit/4dd8787a20e2b74cfcc297253f237e0ac86c9289
  Author: Laszlo Ersek <ler...@redhat.com>
  Date:   2016-10-16 (Sun, 16 Oct 2016)

  Changed paths:
    M OvmfPkg/QemuVideoDxe/Initialize.c
    M OvmfPkg/QemuVideoDxe/VbeShim.c

  Log Message:
  -----------
  OvmfPkg/QemuVideoDxe: upgrade VERBOSE debug messages to INFO

In commit 5b2291f9567a ("OvmfPkg: QemuVideoDxe uses
MdeModulePkg/FrameBufferLib"), QemuVideoDxe was rebased to
FrameBufferBltLib.

The FrameBufferBltLib instance added in commit b1ca386074bd
("MdeModulePkg: Add FrameBufferBltLib library instance") logs many
messages on the VERBOSE level; for example, a normal boot with OVMF can
produce 500+ "VideoFill" messages, dependent on the progress bar, when the
VERBOSE bit is set in PcdDebugPrintErrorLevel. While FrameBufferBltLib is
certainly allowed to log such messages on the VERBOSE level, we should
separate those frequent messages from the (infrequent) ones produced by
QemuVideoDxe itself.

QemuVideoDxe logs VERBOSE messages in three locations (in two functions)
at the moment. All of them are infrequent: both QemuVideoBochsModeSetup()
and InstallVbeShim() are called from QemuVideoControllerDriverStart(),
that is, when a device is bound. Upgrade these messages to INFO level, so
that VERBOSE can be disabled in PcdDebugPrintErrorLevel -- perhaps
selectively for OvmfPkg/QemuVideoDxe -- without hiding these infrequent
messages.

Cc: Jordan Justen <jordan.l.jus...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>


Compare: https://github.com/tianocore/edk2/compare/5b54c92a6537...4dd8787a20e2
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to