Branch: refs/heads/master Home: https://github.com/tianocore/edk2 Commit: 82e0c422b2166434d78d0e03434e23d4226c6040 https://github.com/tianocore/edk2/commit/82e0c422b2166434d78d0e03434e23d4226c6040 Author: Dandan Bi <dandan...@intel.com> Date: 2019-09-25 (Wed, 25 Sep 2019)
Changed paths: M EmbeddedPkg/Application/AndroidFastboot/Arm/BootAndroidBootImg.c M EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c Log Message: ----------- EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the callers in EmbeddedPkg which don't have the policy to defer the execution of the image. Cc: Leif Lindholm <leif.lindh...@linaro.org> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Philippe Mathieu-Daude <phi...@redhat.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992 Signed-off-by: Dandan Bi <dandan...@intel.com> Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Acked-by: Laszlo Ersek <ler...@redhat.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> Commit: 51a3985cbbe17257b7a5db71842960b76e20e1d6 https://github.com/tianocore/edk2/commit/51a3985cbbe17257b7a5db71842960b76e20e1d6 Author: Dandan Bi <dandan...@intel.com> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Log Message: ----------- MdeModulePkg/DxeCapsuleLibFmp: Unload image on EFI_SECURITY_VIOLATION For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the callers in DxeCapsuleLibFmp which don't have the policy to defer the execution of the image. Cc: Jian J Wang <jian.j.w...@intel.com> Cc: Hao A Wu <hao.a...@intel.com> Cc: Liming Gao <liming....@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Philippe Mathieu-Daude <phi...@redhat.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992 Signed-off-by: Dandan Bi <dandan...@intel.com> Reviewed-by: Hao A Wu <hao.a...@intel.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> Commit: f7fdd620e81dd590414184e562b9058f95480b0e https://github.com/tianocore/edk2/commit/f7fdd620e81dd590414184e562b9058f95480b0e Author: Dandan Bi <dandan...@intel.com> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c M MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c M MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c Log Message: ----------- MdeModulePkg/UefiBootManager: Unload image on EFI_SECURITY_VIOLATION For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the callers in UefiBootManagerLib which don't have the policy to defer the execution of the image. Cc: Jian J Wang <jian.j.w...@intel.com> Cc: Hao A Wu <hao.a...@intel.com> Cc: Ray Ni <ray...@intel.com> Cc: Zhichao Gao <zhichao....@intel.com> Cc: Liming Gao <liming....@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Philippe Mathieu-Daude <phi...@redhat.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992 Signed-off-by: Dandan Bi <dandan...@intel.com> Reviewed-by: Zhichao Gao <zhichao....@intel.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> Commit: 2184ededd36b5221699087a8e084e82ee3b3908a https://github.com/tianocore/edk2/commit/2184ededd36b5221699087a8e084e82ee3b3908a Author: Dandan Bi <dandan...@intel.com> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c Log Message: ----------- MdeModulePkg/PlatformDriOverride: Unload image on EFI_SECURITY_VIOLATION For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the caller in PlatformDriOverrideDxe which don't have the policy to defer the execution of the image. Cc: Jian J Wang <jian.j.w...@intel.com> Cc: Hao A Wu <hao.a...@intel.com> Cc: Liming Gao <liming....@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Philippe Mathieu-Daude <phi...@redhat.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992 Signed-off-by: Dandan Bi <dandan...@intel.com> Reviewed-by: Hao A Wu <hao.a...@intel.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> Commit: c671c9106c52f4bd000ab8857eecd19574c70dbd https://github.com/tianocore/edk2/commit/c671c9106c52f4bd000ab8857eecd19574c70dbd Author: Dandan Bi <dandan...@intel.com> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M ShellPkg/Application/Shell/ShellManParser.c M ShellPkg/Library/UefiShellDebug1CommandsLib/LoadPciRom.c M ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c Log Message: ----------- ShellPkg: Unload image on EFI_SECURITY_VIOLATION For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the callers in ShellPkg which don't have the policy to defer the execution of the image. Cc: Ray Ni <ray...@intel.com> Cc: Zhichao Gao <zhichao....@intel.com> Cc: Laszlo Ersek <ler...@redhat.com> Cc: Philippe Mathieu-Daude <phi...@redhat.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992 Signed-off-by: Dandan Bi <dandan...@intel.com> Reviewed-by: Zhichao Gao <zhichao....@intel.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> Compare: https://github.com/tianocore/edk2/compare/590c9d58280b...c671c9106c52 _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits