Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 8e6bb64fe43e5be7bf3becfbc5dbcdc90ab6425c
https://github.com/tianocore/edk2/commit/8e6bb64fe43e5be7bf3becfbc5dbcdc90ab6425c
Author: Sunny Wang <sunny.w...@arm.com>
Date: 2021-07-29 (Thu, 29 Jul 2021)
Changed paths:
M EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
Log Message:
-----------
EmbeddedPkg/VirtualRealTimeClockLib: Fix SetTime issues
This patch fixes two issues below:
1. SCT SetTime_Func failures.
- https://github.com/pftf/RPi4/issues/164
2. Using shell time and date commands to set time can't work.
The problem is that gRT->SetTime always returns EFI_INVALID_PARAMETER
error status.
The root cause is that LibSetTime() sets RtcEpochSeconds variable with
inconsistent attributes. One is without EFI_VARIABLE_NON_VOLATILE,
the other one is with EFI_VARIABLE_NON_VOLATILE. That caused that the
variable driver returns EFI_INVALID_PARAMETER. Per UEFI spec, if a
preexisting variable is rewritten with different attributes,
SetVariable() shall not modify the variable and shall return
EFI_INVALID_PARAMETER.
Therefore, the solution is to add EFI_VARIABLE_NON_VOLATILE attribute
to the first EfiSetVariable() call to make two calls consistent.
By the way, this patch also fix a minor issue with a debug message.
Signed-off-by: Sunny Wang <sunny.w...@arm.com>
Reviewed-by: Pete Batard <p...@akeo.ie>
Tested-by: Pete Batard <p...@akeo.ie>
Commit: 610bcc69ed3d1e8c016332a1862465d41d95dd6c
https://github.com/tianocore/edk2/commit/610bcc69ed3d1e8c016332a1862465d41d95dd6c
Author: Philippe Mathieu-Daude <phi...@redhat.com>
Date: 2021-07-29 (Thu, 29 Jul 2021)
Changed paths:
M ArmVirtPkg/ArmVirt.dsc.inc
M ArmVirtPkg/ArmVirtKvmTool.fdf
M ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
M ArmVirtPkg/ArmVirtXen.fdf
Log Message:
-----------
ArmVirtPkg: Remove meaningless comment
The "Shell Embedded Boot Loader" description (added in
commit 6f5872b1f401) does not add any value, remove it.
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Leif Lindholm <l...@nuviainc.com>
Cc: Sami Mujawar <sami.muja...@arm.com>
Cc: Julien Grall <jul...@xen.org>
Suggested-by: Laszlo Ersek <ler...@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com>
Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
Compare: https://github.com/tianocore/edk2/compare/514b3aa08ece...610bcc69ed3d
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
