Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: cb0d24637dfdd869618b9635dfb8e3b0746393a6
https://github.com/tianocore/edk2/commit/cb0d24637dfdd869618b9635dfb8e3b0746393a6
Author: Lin, Gary (HPS OE-Linux) <gary....@hpe.com>
Date: 2021-08-31 (Tue, 31 Aug 2021)
Changed paths:
M OvmfPkg/XenPlatformPei/Platform.c
M OvmfPkg/XenPlatformPei/XenPlatformPei.inf
Log Message:
-----------
OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
There are several functions in OvmfPkg/Library using
QemuFwCfgS3Enabled() to detect the S3 support status. However, in
MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since
InitializeXenPlatform() didn't set PcdAcpiS3Enable as
InitializePlatform() did, this made the inconsistency between
drivers/functions.
For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped
S3BootScript because the default value is FALSE. On the other hand,
PlatformBootManagerBeforeConsole() from OvmfPkg/Library called
QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked
SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so
SaveS3BootScript() asserted due to EFI_NOT_FOUND.
This issue mainly affects "HVM Direct Kernel Boot". When used,
"fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in
that case.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
Signed-off-by: Gary Lin <gary....@hpe.com>
Reviewed-by: Anthony PERARD <anthony.per...@citrix.com>
Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
Reviewed-by: Jiewen Yao <jiewen....@intel.com>
Tested-by: Jim Fehlig <jfeh...@suse.com>
Commit: 28152333bccb778b62e6e97446b28bfa0e92ef82
https://github.com/tianocore/edk2/commit/28152333bccb778b62e6e97446b28bfa0e92ef82
Author: Lin, Gary (HPS OE-Linux) <gary....@hpe.com>
Date: 2021-08-31 (Tue, 31 Aug 2021)
Changed paths:
M OvmfPkg/Library/LockBoxLib/LockBoxDxe.c
M OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf
Log Message:
-----------
OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
To avoid the potential inconsistency between PcdAcpiS3Enable and
QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect
S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
Signed-off-by: Gary Lin <gary....@hpe.com>
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>
Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
Reviewed-by: Jiewen Yao <jiewen....@intel.com>
Tested-by: Jim Fehlig <jfeh...@suse.com>
Commit: 52e2dabc0f8d3af09c213072ce8ba734302f585d
https://github.com/tianocore/edk2/commit/52e2dabc0f8d3af09c213072ce8ba734302f585d
Author: Lin, Gary (HPS OE-Linux) <gary....@hpe.com>
Date: 2021-08-31 (Tue, 31 Aug 2021)
Changed paths:
M OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
M OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
Log Message:
-----------
OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support
To avoid the potential inconsistency between PcdAcpiS3Enable and
QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to
detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
Signed-off-by: Gary Lin <gary....@hpe.com>
Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
Reviewed-by: Jiewen Yao <jiewen....@intel.com>
Tested-by: Jim Fehlig <jfeh...@suse.com>
Commit: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7
https://github.com/tianocore/edk2/commit/5b5f10d7465004e3e40ec1f50a3b490b4db595e7
Author: Lin, Gary (HPS OE-Linux) <gary....@hpe.com>
Date: 2021-08-31 (Tue, 31 Aug 2021)
Changed paths:
M OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c
M OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf
Log Message:
-----------
OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
To avoid the potential inconsistency between PcdAcpiS3Enable and
QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect
S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573
Signed-off-by: Gary Lin <gary....@hpe.com>
Reviewed-by: Gerd Hoffmann <kra...@redhat.com>
Reviewed-by: Jiewen Yao <jiewen....@intel.com>
Tested-by: Jim Fehlig <jfeh...@suse.com>
Compare: https://github.com/tianocore/edk2/compare/cae735f61328...5b5f10d74650
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
