Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 69877614fdeef64b8d1d6f21d5a209dce22983b7
https://github.com/tianocore/edk2/commit/69877614fdeef64b8d1d6f21d5a209dce22983b7
Author: Michael D Kinney <michael.d.kin...@intel.com>
Date: 2021-11-29 (Mon, 29 Nov 2021)
Changed paths:
M .pytool/Plugin/EccCheck/EccCheck.py
Log Message:
-----------
.pytool/Plugin/EccCheck: Remove RevertCode()
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986
The RevertCode() method uses git reset which can remove
local changes. Instead of modifying the local files, a
copy of the package passed into the EccCheck tool is
copied to a temp directory in Build/ecctemp. This same
temp directory is also used for exception.xml. The working
directory used by ECC is also set to this same temp
directory. The combination of these changes eliminates
operations that that modified the git state.
Cc: Sean Brogan <sean.bro...@microsoft.com>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Michael Kubacki <michael.kuba...@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com>
Acked-by: Sean Brogan <sean.bro...@microsoft.com>
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Commit: 854462bd347974da73d36519c8187554b7719680
https://github.com/tianocore/edk2/commit/854462bd347974da73d36519c8187554b7719680
Author: Michael D Kinney <michael.d.kin...@intel.com>
Date: 2021-11-29 (Mon, 29 Nov 2021)
Changed paths:
M .pytool/Plugin/EccCheck/EccCheck.py
Log Message:
-----------
.pytool/Plugin/EccCheck: Remove temp directory on exception
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986
Add try/except to RunBuildPlugin() to remove temporary
directory if a KeyboardInterrupt exception or an unexpected
exception is detected.
Cc: Sean Brogan <sean.bro...@microsoft.com>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Michael Kubacki <michael.kuba...@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com>
Acked-by: Sean Brogan <sean.bro...@microsoft.com>
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Commit: 3019f1bbabf1ae413713a9015c07d7cb7dbcb968
https://github.com/tianocore/edk2/commit/3019f1bbabf1ae413713a9015c07d7cb7dbcb968
Author: Michael D Kinney <michael.d.kin...@intel.com>
Date: 2021-11-29 (Mon, 29 Nov 2021)
Changed paths:
M .pytool/Plugin/EccCheck/EccCheck.py
Log Message:
-----------
.pytool/Plugin/EccCheck: Add performance optimizations
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986
Improve the performance of EccCheck by using a temp file
instead of stdout to capture the results of the git diff
commands. If a large patch set is passed into EccCheck,
using stdout could be slow and also added the large diff
content to the build log that is redundant information.
A second performance improvement is to filter the
modified directories to remove duplicate directories.
Complex libraries and modules that have subdirectories
with sources would be scanned twice if there were source
changes in both the main directory and subdirectories.
Filter out the subdirectories from the modified directory
list when this case is detected.
Cc: Sean Brogan <sean.bro...@microsoft.com>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Michael Kubacki <michael.kuba...@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com>
Acked-by: Sean Brogan <sean.bro...@microsoft.com>
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Compare: https://github.com/tianocore/edk2/compare/ef9a059cdb15...3019f1bbabf1
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
