Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 179efe5d69214ba95cdcb9dcbc5845a9f0114146
https://github.com/tianocore/edk2/commit/179efe5d69214ba95cdcb9dcbc5845a9f0114146
Author: Michael Kubacki <michael.kuba...@microsoft.com>
Date: 2022-11-09 (Wed, 09 Nov 2022)
Changed paths:
M BaseTools/Source/C/EfiRom/EfiRom.c
M BaseTools/Source/C/GenFv/GenFvInternalLib.c
M BaseTools/Source/C/GenFw/Elf32Convert.c
M BaseTools/Source/C/GenFw/Elf64Convert.c
M BaseTools/Source/C/GenSec/GenSec.c
Log Message:
-----------
BaseTools: Fix wrong type of arguments to formatting functions
Fixes issues found with the cpp/wrong-type-format-argument CodeQL
rule in BaseTools.
Reference:
https://cwe.mitre.org/data/definitions/686.html
The following CodeQL errors are resolved:
1. Check failure on line 1115 in
BaseTools/Source/C/EfiRom/EfiRom.c
- This argument should be of type 'int' but is of type 'char *'.
- This argument should be of type 'int' but is of type 'signed
char *'.
2. Check failure on line 359 in
BaseTools/Source/C/GenFw/Elf32Convert.c
- This argument should be of type 'CHAR8 *' but is of type
'unsigned int'.
3. Check failure on line 1841 in
BaseTools/Source/C/GenFw/Elf64Convert.c
- This argument should be of type 'unsigned int' but is of type
'unsigned long long'.
4. Check failure on line 1871 in
BaseTools/Source/C/GenFw/Elf64Convert.c
- This argument should be of type 'unsigned int' but is of type
'unsigned long long'.
5. Check failure on line 2400 in
BaseTools/Source/C/GenFv/GenFvInternalLib.c
- This argument should be of type 'unsigned long long' but is of
type 'unsigned int'.
6. Check failure on line 1099 in
BaseTools/Source/C/GenFw/Elf64Convert.c
- This argument should be of type 'CHAR8 *' but is of type
'unsigned int'.
7. Check failure on line 1098 in
BaseTools/Source/C/GenSec/GenSec.c
- This argument should be of type 'CHAR8 *' but is of type
'char **'.
8. Check failure on line 911 in
BaseTools/Source/C/GenSec/GenSec.c
- This argument should be of type 'CHAR8 *' but is of type
'char **'.
Cc: Bob Feng <bob.c.f...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.c...@intel.com>
Cc: Sean Brogan <sean.bro...@microsoft.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
Reviewed-by: Sean Brogan <sean.bro...@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
Commit: b0fd3097193d9c6825979e57e78e6278163bfd8e
https://github.com/tianocore/edk2/commit/b0fd3097193d9c6825979e57e78e6278163bfd8e
Author: Michael Kubacki <michael.kuba...@microsoft.com>
Date: 2022-11-09 (Wed, 09 Nov 2022)
Changed paths:
M .github/codeql/codeql-config.yml
M .github/codeql/edk2.qls
Log Message:
-----------
edk2.qls: Allow error severity results and add new queries
The query cpp/conditionallyuninitializedvariable was initially
enabled with the CodeQL code because work was in progress on those
changes. The results were filtered out so CodeQL passed so we could
verify the CodeQL workflow without impacting CI results.
This change allows error severity messages and substitutes that query
with two queries that do not return failures. This allows these
queries to find future problems and prepares the CodeQL workflow to
catch future failures as queries are enabled.
Cc: Sean Brogan <sean.bro...@microsoft.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
Reviewed-by: Sean Brogan <sean.bro...@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
Compare: https://github.com/tianocore/edk2/compare/0be81a4d8381...b0fd3097193d
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
