Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 206168e83f0901cbc1815ef5df4ac6598ad9721b
      
https://github.com/tianocore/edk2/commit/206168e83f0901cbc1815ef5df4ac6598ad9721b
  Author: Rebecca Cran <rebe...@quicinc.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M BaseTools/Source/C/DevicePath/GNUmakefile
    M BaseTools/Source/C/LzmaCompress/GNUmakefile
    M BaseTools/Source/C/Makefiles/app.makefile
    M BaseTools/Source/C/Makefiles/footer.makefile
    M BaseTools/Source/C/Makefiles/header.makefile
    M BaseTools/Source/C/VfrCompile/GNUmakefile
    M BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
    M BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile
    M BaseTools/Source/Python/Workspace/DscBuildData.py

  Log Message:
  -----------
  BaseTools: Allow users to specify compiler to use with make CC= CXX=

In https://bugzilla.tianocore.org/show_bug.cgi?id=2842 clang support was
added by having users specify "make CXX=llvm" when building BaseTools.

The Makefile then sees that and sets CC=$(CLANG_BIN)clang and
CXX=$(CLANG_BIN)clang++. That requires that the executables 'clang' and
'clang++' exist and for example aren't named 'clang-17' and
'clang++-17'. Also, it's an unusual way of specifying the compiler,
since many users will expect to be able to override CC and CXX on the
make command line.

Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC
and BUILD_CXX) and using the standard name 'LDFLAGS' instead of
'LFLAGS'. This allows clang to be used by running
'make -C BaseTools CC=clang CXX=clang++'.

Signed-off-by: Rebecca Cran <rebe...@quicinc.com>
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>


  Commit: 728ff1da339695ac73e7731d1b5f1d912ab01142
      
https://github.com/tianocore/edk2/commit/728ff1da339695ac73e7731d1b5f1d912ab01142
  Author: Rebecca Cran <rebe...@quicinc.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M BaseTools/Source/C/DevicePath/GNUmakefile
    M BaseTools/Source/C/Makefiles/header.makefile
    M BaseTools/Source/C/VfrCompile/GNUmakefile
    M BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile
    M BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile

  Log Message:
  -----------
  BaseTools: Allow users to build with clang using CC=clang CXX=clang++

In https://bugzilla.tianocore.org/show_bug.cgi?id=2842 clang support was
added by having users specify "make CXX=llvm" when building BaseTools.

The Makefile then sees that and sets CC=$(CLANG_BIN)clang and
CXX=$(CLANG_BIN)clang++. That requires that the executables 'clang' and
'clang++' exist and for example aren't named 'clang-17' and
'clang++-17'. Also, it's an unusual way of specifying the compiler,
since many users will expect to be able to override CC and CXX on the
make command line.

Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC
and BUILD_CXX) and using the standard name 'LDFLAGS' instead of
'LFLAGS'. This allows clang to be used by running
'make -C BaseTools CC=clang CXX=clang++'.

Signed-off-by: Rebecca Cran <rebe...@quicinc.com>
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>


  Commit: a56ee36c494cb1dfe795259b2cba706ef55b5212
      
https://github.com/tianocore/edk2/commit/a56ee36c494cb1dfe795259b2cba706ef55b5212
  Author: Rebecca Cran <rebe...@quicinc.com>
  Date:   2023-04-05 (Wed, 05 Apr 2023)

  Changed paths:
    M BaseTools/Source/C/Makefiles/header.makefile

  Log Message:
  -----------
  BaseTools: Build against C++14 when building with clang

clang 17 defaults to C++17, where the 'register' keyword is deprecated
and the warning changed to an error. To avoid build errors, compile
against C++14 by specifying '-std=c++14' in CXXFLAGS.

Signed-off-by: Rebecca Cran <rebe...@quicinc.com>
Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>


Compare: https://github.com/tianocore/edk2/compare/cdd79996c217...a56ee36c494c


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to