Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: dc5f2905ebfdf68ae28ce1081d435af0f8641dd9
      
https://github.com/tianocore/edk2/commit/dc5f2905ebfdf68ae28ce1081d435af0f8641dd9
  Author: Benjamin Doron <benjamin.doro...@gmail.com>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
    M UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf
    M UefiPayloadPkg/UefiPayloadPkg.dec
    M UefiPayloadPkg/UefiPayloadPkg.dsc

  Log Message:
  -----------
  UefiPayloadPkg: Always build MemoryTypeInformation HOB for DXE GCD

MemoryType information assists GCD with defragmenting the memory map.
When the DXE core starts, GCD adds memory descriptors for the resource
descriptors HOBs. This allocates heap space which can be reused later
as the bins by memory type. It seems memory allocation prefers low
ranges.

It seems "below 4G" is an artifact of this heap reuse. However, the
memory type information determines the DXE core's
`MinimalMemorySizeNeeded`, determining which system memory descriptor
HOB may be used by DXE. Furthermore, it's important that the memory
type information be correct, for an S4 memory map.

Therefore, follow other bootloaders, such as [MinPlatform][1], and do
this unconditionally. As of [edk2-stable202011][2], it was.

[1]: 
https://github.com/tianocore/edk2-platforms/blob/b6f96743891be51541184bf61dd2970c008e2c43/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c#L164-L201
[2]: 
https://github.com/tianocore/edk2/blob/edk2-stable202011/UefiPayloadPkg/BlSupportPei/BlSupportPei.c#L462-L466

Cc: Guo Dong <guo.d...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: James Lu <james...@intel.com>
Cc: Gua Guo <gua....@intel.com>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Benjamin Doron <benjamin.doro...@gmail.com>


  Commit: 89520115b89d755ae79f61850c356aae4be2d9ad
      
https://github.com/tianocore/edk2/commit/89520115b89d755ae79f61850c356aae4be2d9ad
  Author: Sean Rhodes <sean@starlabs.systems>
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
    M UefiPayloadPkg/UefiPayloadPkg.dec

  Log Message:
  -----------
  UefiPayloadPkg: Update default memory type information for S4

Copied values from OVMF, these are sufficient for a debug build.

Cc: Guo Dong <guo.d...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: James Lu <james...@intel.com>
Cc: Gua Guo <gua....@intel.com>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Benjamin Doron <benjamin.doro...@gmail.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>


Compare: https://github.com/tianocore/edk2/compare/b991aec0509f...89520115b89d


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to