Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: f384303dc563fab096f265a0227a13a3df403a70
      
https://github.com/tianocore/edk2/commit/f384303dc563fab096f265a0227a13a3df403a70
  Author: Michael Roth <michael.r...@amd.com>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M OvmfPkg/AmdSevDxe/AmdSevDxe.c

  Log Message:
  -----------
  OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

The SEV-SNP Confidential Computing blob contains metadata that should
remain accessible for the life of the guest. Allocate it as
EfiACPIReclaimMemory to ensure the memory isn't overwritten by the guest
operating system later.

Reported-by: Dov Murik <dovmu...@linux.ibm.com>
Suggested-by: Dov Murik <dovmu...@linux.ibm.com>
Reviewed-by: Dov Murik <dovmu...@linux.ibm.com>
Reviewed-by: Tom Lendacky <thomas.lenda...@amd.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Michael Roth <michael.r...@amd.com>


  Commit: e5c7d0b017dd20a283ab5765a5d444ab38f7a4c6
      
https://github.com/tianocore/edk2/commit/e5c7d0b017dd20a283ab5765a5d444ab38f7a4c6
  Author: Roth, Michael via groups.io <Michael.Roth=amd....@groups.io>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M OvmfPkg/AmdSevDxe/AmdSevDxe.c
    M OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h

  Log Message:
  -----------
  OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition

The Confidential Computing blob defined here is intended to match the
definition defined by linux guest kernel. Previously, both definitions
relied on natural alignment, but that relies on both OVMF and kernel
being compiled as 64-bit. While there aren't currently any plans to
enable SNP support for 32-bit compilations, the kernel definition has
since been updated to use explicit padding/reserved fields to avoid
this dependency. Update OVMF to match that definition.

While at it, also fix up the Reserved fields to match the numbering
used in the kernel.

No functional changes (for currently-supported environments, at least).

Reviewed-by: Tom Lendacky <thomas.lenda...@amd.com>
Acked-by: Jiewen Yao <jiewen....@intel.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Michael Roth <michael.r...@amd.com>


  Commit: ce781cf8bb5e72d130b1db6a242c3bd312f5eb40
      
https://github.com/tianocore/edk2/commit/ce781cf8bb5e72d130b1db6a242c3bd312f5eb40
  Author: Roth, Michael via groups.io <Michael.Roth=amd....@groups.io>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M OvmfPkg/Library/CcExitLib/CcExitVcHandler.c

  Log Message:
  -----------
  OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation

CPUID leaf 0xD sub-leafs 0x0 and 0x1 contain cumulative sizes for the
enabled XSave areas. Those sizes are calculated by tallying up all the
other sub-leafs that contain per-area size information for XSave areas
that are currently enabled in XCr0/XSS. The current check has the logic
inverted. Fix that.

This doesn't seem to cause problems currently, but could in the future
if OVMF made more extensive use of XSave areas. It was noticed while
implementing SNP-related tests for KVM Unit Tests, which re-uses the
OVMF #VC handler in some cases.

Reported-by: Pavan Kumar Paluri <papal...@amd.com>
Cc: Pavan Kumar Paluri <papal...@amd.com>
Reviewed-by: Tom Lendacky <thomas.lenda...@amd.com>
Acked-by: Jiewen Yao <jiewen....@intel.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Michael Roth <michael.r...@amd.com>


  Commit: edacc551e6586258ab046dd852f65d674e3e2af0
      
https://github.com/tianocore/edk2/commit/edacc551e6586258ab046dd852f65d674e3e2af0
  Author: Roth, Michael via groups.io <Michael.Roth=amd....@groups.io>
  Date:   2023-04-26 (Wed, 26 Apr 2023)

  Changed paths:
    M OvmfPkg/Library/CcExitLib/CcExitVcHandler.c

  Log Message:
  -----------
  OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

Currently OVMF tries to rely on the base size advertised via the CPUID
table entries corresponding to leaf 0xD, sub-leafs 0x0/0x1. This will
generally work for KVM guests, but might not for other SEV-SNP
hypervisor implementations. Make the handling more robust by simply
using the base area size documented by the APM.

Reviewed-by: Tom Lendacky <thomas.lenda...@amd.com>
Acked-by: Jiewen Yao <jiewen....@intel.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Michael Roth <michael.r...@amd.com>


Compare: https://github.com/tianocore/edk2/compare/ede0bd149640...edacc551e658


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to