Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 5e8958472c45bb31bfa249cf8e4c5a94c9f81839
      
https://github.com/tianocore/edk2/commit/5e8958472c45bb31bfa249cf8e4c5a94c9f81839
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c

  Log Message:
  -----------
  MdeModulePkg/SataControllerDxe: Clean up error handling in Start()

Clean up error handling using cascading labels + goto.

(port of commit 379b179 + bcab714)

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Hao A Wu <hao.a...@intel.com>


  Commit: 897a2b447e0f71eb0d102ad707f3688c102d9cec
      
https://github.com/tianocore/edk2/commit/897a2b447e0f71eb0d102ad707f3688c102d9cec
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c

  Log Message:
  -----------
  MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO level

When a UEFI_DRIVER attempts to open a protocol interface with BY_DRIVER
attribute that it already has open with BY_DRIVER attribute,
OpenProtocol() returns EFI_ALREADY_STARTED. This is not an error. The
UEFI-2.7 spec currently says,

> EFI_ALREADY_STARTED -- Attributes is BY_DRIVER and there is an item on
>                        the open list with an attribute of BY_DRIVER
>                        whose agent handle is the same as AgentHandle.

Downgrade the log mask for this one condition to DEBUG_INFO, in
SataControllerStart(). This will match the log mask of the other two
informative messages in this function.

(ported from commit 5dfba97)

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Hao A Wu <hao.a...@intel.com>


  Commit: 82b81c64643bb08ba5bf928c5861d6e82b12f160
      
https://github.com/tianocore/edk2/commit/82b81c64643bb08ba5bf928c5861d6e82b12f160
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c

  Log Message:
  -----------
  MdeModulePkg/SataControllerDxe: Remove useless null check

ASSERT (Private != NULL) already covers this check.
See commit 81310a6.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Hao A Wu <hao.a...@intel.com>


  Commit: 2bc46e67b67c64455f3fccf22b533fad4393a563
      
https://github.com/tianocore/edk2/commit/2bc46e67b67c64455f3fccf22b533fad4393a563
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M MdeModulePkg/Bus/Pci/SataControllerDxe/SataController.c

  Log Message:
  -----------
  MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL)

ASSERT (Private != NULL) (where Private = CR(...)) is ineffective as
CR(Ptr, Type, Member, Sig) either returns Ptr - offsetof(Type, Member),
or ASSERTS on the signature, so it's unlikely to ever return NULL (must
be passed a pointer = member's offset, or in this case, 0x4).

ASSERT on This != NULL instead.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Hao A Wu <hao.a...@intel.com>


  Commit: f5137e1a549e31571ea75c994f06f8767d428279
      
https://github.com/tianocore/edk2/commit/f5137e1a549e31571ea75c994f06f8767d428279
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/OvmfPkgIa32.dsc
    M OvmfPkg/OvmfPkgIa32.fdf
    M OvmfPkg/OvmfPkgIa32X64.dsc
    M OvmfPkg/OvmfPkgIa32X64.fdf
    M OvmfPkg/OvmfPkgX64.dsc
    M OvmfPkg/OvmfPkgX64.fdf

  Log Message:
  -----------
  OvmfPkg: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for OvmfPkg{Ia32, X64, Ia32X64} platforms.

Tested-by: Gerd Hoffmann <kra...@redhat.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>


  Commit: bc59ede1707936c8539a60c96d6e6b5a07a4bcbd
      
https://github.com/tianocore/edk2/commit/bc59ede1707936c8539a60c96d6e6b5a07a4bcbd
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/Microvm/MicrovmX64.dsc
    M OvmfPkg/Microvm/MicrovmX64.fdf

  Log Message:
  -----------
  OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for the Microvm platform.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>
Acked-by: Gerd Hoffmann <kra...@redhat.com>


  Commit: d85b84e2017104b6bc1cd9b5c5d120318953246d
      
https://github.com/tianocore/edk2/commit/d85b84e2017104b6bc1cd9b5c5d120318953246d
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/Bhyve/BhyveX64.dsc
    M OvmfPkg/Bhyve/BhyveX64.fdf

  Log Message:
  -----------
  OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for the Bhyve platform.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Acked-by: Peter Grehan <gre...@freebsd.org>
Acked-by: Corvin Köhne <corv...@freebsd.org>


  Commit: b26359c176376d2634d3480bed6ac58c430d4ef1
      
https://github.com/tianocore/edk2/commit/b26359c176376d2634d3480bed6ac58c430d4ef1
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/CloudHv/CloudHvX64.dsc
    M OvmfPkg/CloudHv/CloudHvX64.fdf

  Log Message:
  -----------
  OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for the CloudHv platform.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>
Acked-by: Gerd Hoffmann <kra...@redhat.com>


  Commit: 069d4035874cfaeb650d42a95f0841d25f185c6e
      
https://github.com/tianocore/edk2/commit/069d4035874cfaeb650d42a95f0841d25f185c6e
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/IntelTdx/IntelTdxX64.dsc
    M OvmfPkg/IntelTdx/IntelTdxX64.fdf

  Log Message:
  -----------
  OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for the IntelTdx platform.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>


  Commit: 07c7e683607c295950edb3652a9edd549b0dd753
      
https://github.com/tianocore/edk2/commit/07c7e683607c295950edb3652a9edd549b0dd753
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/AmdSev/AmdSevX64.dsc
    M OvmfPkg/AmdSev/AmdSevX64.fdf

  Log Message:
  -----------
  OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for the AmdSev platform.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>
Acked-by: Gerd Hoffmann <kra...@redhat.com>


  Commit: 77fee3a9d8f2d70150d2e62805d2598ca93827c7
      
https://github.com/tianocore/edk2/commit/77fee3a9d8f2d70150d2e62805d2598ca93827c7
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    M OvmfPkg/OvmfXen.dsc
    M OvmfPkg/OvmfXen.fdf

  Log Message:
  -----------
  OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe

Replace the OVMF-specific SataControllerDxe (to be later removed) with
the generic, MdeModulePkg one, for the OvmfXen platform.

Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>
Acked-by: Anthony PERARD <anthony.per...@citrix.com>


  Commit: 41abf00bf98e36830974bd669ab7ec3679bd5e67
      
https://github.com/tianocore/edk2/commit/41abf00bf98e36830974bd669ab7ec3679bd5e67
  Author: Pedro Falcato <pedro.falc...@gmail.com>
  Date:   2023-06-01 (Thu, 01 Jun 2023)

  Changed paths:
    R OvmfPkg/SataControllerDxe/ComponentName.c
    R OvmfPkg/SataControllerDxe/SataController.c
    R OvmfPkg/SataControllerDxe/SataController.h
    R OvmfPkg/SataControllerDxe/SataControllerDxe.inf

  Log Message:
  -----------
  OvmfPkg: Remove SataControllerDxe

Now that OvmfPkg/SataControllerDxe and its MdeModulePkg counterpart have
been unified, and no in-tree uses of the OVMF variant remain, let's
delete it.

Tested-by: Gerd Hoffmann <kra...@redhat.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Signed-off-by: Pedro Falcato <pedro.falc...@gmail.com>
Acked-by: Ard Biesheuvel <a...@kernel.org>
Reviewed-by: Laszlo Ersek <ler...@redhat.com>


Compare: https://github.com/tianocore/edk2/compare/ded1d5414b5a...41abf00bf98e


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to