Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: a52044a9e602bc168cdf5d73a48952bfc9edb521
      
https://github.com/tianocore/edk2/commit/a52044a9e602bc168cdf5d73a48952bfc9edb521
  Author: Gerd Hoffmann <kra...@redhat.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    M OvmfPkg/IoMmuDxe/IoMmuBuffer.c

  Log Message:
  -----------
  OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer

Searching for an unused bounce buffer in mReservedMemBitmap and
reserving the buffer by flipping the bit is a critical section
which must not be interrupted.  Raise the TPL level to ensure
that.

Without this fix it can happen that IoMmuDxe hands out the same
bounce buffer twice, causing trouble down the road.  Seen happening
in practice with VirtioNetDxe setting up the network interface (and
calling into IoMmuDxe from a polling timer callback) in parallel with
Boot Manager doing some disk I/O.  An ASSERT() in VirtioNet caught
the buffer inconsistency.

Full story with lots of details and discussions is available here:
https://bugzilla.redhat.com/show_bug.cgi?id=2211060

Signed-off-by: Gerd Hoffmann <kra...@redhat.com>




_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to