Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: c7c1170a4568ecc0f63e14ca6a844d40f47519a9
https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f47519a9
Author: Ranbir Singh <ranbir.sin...@dell.com>
Date: 2023-08-02 (Wed, 02 Aug 2023)
Changed paths:
M MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c
Log Message:
-----------
MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity issue
Line number 1348 does contain a typecast with UINT32, but it is after
all the operations (16-bit left shift followed by OR'ing) are over.
To avoid any SIGN_EXTENSION, typecast the intermediate result after
16-bit left shift operation immediately with UINT32.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4204
Cc: Hao A Wu <hao.a...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com>
Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com>
Reviewed-by: Hao A Wu <hao.a...@intel.com>
Commit: d11968fcc56cbbffef7d906048b00faea9415447
https://github.com/tianocore/edk2/commit/d11968fcc56cbbffef7d906048b00faea9415447
Author: Ranbir Singh <ranbir.sin...@dell.com>
Date: 2023-08-02 (Wed, 02 Aug 2023)
Changed paths:
M MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c
Log Message:
-----------
MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue
The return value stored in Status after call to SetDriveParameters
is not made of any use thereafter and hence it remains as UNUSED.
Based on Hao's findings (https://edk2.groups.io/g/devel/message/106844),
the successful execution of SetDriveParameters() is not mandatory for
initializing IDE mode of a hard disk device. Hence remove the 'Status'
assignment of the return value from SetDriveParameters() and instead add
error checks & DEBUG_WARN level messages within SetDriveParameters()
function after sending INIT_DRIVE_PARAM & SET_MULTIPLE_MODE ATA commands.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4204
Cc: Hao A Wu <hao.a...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com>
Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com>
Reviewed-by: Hao A Wu <hao.a...@intel.com>
Compare: https://github.com/tianocore/edk2/compare/677f2c6f1509...d11968fcc56c
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
