Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2-libc
  Commit: b693e326a60faa844c8c266024059774acd33da4
      
https://github.com/tianocore/edk2-libc/commit/b693e326a60faa844c8c266024059774acd33da4
  Author: Kloper Dimitry <dimitry.klo...@intel.com>
  Date:   2023-08-23 (Wed, 23 Aug 2023)

  Changed paths:
    M StdLib/LibC/Uefi/Devices/UefiShell/daShell.c

  Log Message:
  -----------
  edk2-libc/StdLib: file descriptor leak in rename()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4529

rename() call leads to a function that makes open() for source file
to be renamed. The resulting file descriptor is never closed.
If you have to rename a couple of files this will quickly exhaust
the descriptor table.
The fix is trivial - just close the fd before returning from the function.

Cc: Rebecca Cran <rebe...@bsdio.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Jayaprakash N <n.jayaprak...@intel.com>
Signed-off-by: Kloper Dimitry <dimitry.klo...@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinn...@intel.com>
Reviewed-by: Jayaprakash N <n.jayaprak...@intel.com>




_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to