Branch: refs/heads/master Home: https://github.com/tianocore/edk2 Commit: f203a6db92eedf03ac544ed270404cb29d3dea7f https://github.com/tianocore/edk2/commit/f203a6db92eedf03ac544ed270404cb29d3dea7f Author: Sami Mujawar <sami.muja...@arm.com> Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths: M OvmfPkg/VirtioScsiDxe/VirtioScsi.c Log Message: ----------- OvmfPkg: Pass correct virtio-scsi request size The patch at "1fc55a3933b0 OvmfPkg: Use heap memory for virtio-scsi request" modified the virtio-scsi request header memory to be allocated from the heap. In doing so the request structure header which was a local variable on the stack was converted to be a pointer. This required adjusting the size computation for the request header to reflect that the structure was changed to a pointer. Unfortunately, this was missed out in the call to VirtioAppendDesc() for enqueuing the request due to which only 8 bytes were being shared with the host instead of the size of the VIRTIO_SCSI_REQ structure which is 51 bytes. This resulted in the following error message to be printed by qemu: "qemu-system-<arch>: wrong size for virtio-scsi headers" and the virtio-scsi functionality degraded. Therefore, pass the correct size of the virtio-scsi request header when enqueuing the request. Reported-by: Aithal Srikanth <srait...@amd.com> Tested-by: Aithal Srikanth <srait...@amd.com> Signed-off-by: Sami Mujawar <sami.muja...@arm.com> To unsubscribe from these emails, change your notification settings at https://github.com/tianocore/edk2/settings/notifications _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits