Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 01735bbe4a46a6fb7d5d739d0fc5a14897ad18da
      
https://github.com/tianocore/edk2/commit/01735bbe4a46a6fb7d5d739d0fc5a14897ad18da
  Author: Oliver Smith-Denny <o...@linux.microsoft.com>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    M MdeModulePkg/Core/Dxe/Gcd/Gcd.c

  Log Message:
  -----------
  MdeModulePkg: Gcd: Only Update gMemoryMap Attributes if Correct GCD Type

Currently whenever gDS->SetMemorySpaceCapabilities() is called, it
attempts to set the corresponding attributes in the gMemoryMap
descriptor. However, gMemoryMap only contains entries from GCD types
EfiGcdMemoryTypeSystemMemory and EfiGcdMemoryTypeMoreReliable, so
for all other types a failure is reported in the code. This is a
failure that is expected, so it does not provide value and can
lead to real failures being ignored.

This patch updates the gDS->SetMemorySpaceCapabilities() code to
only call into updating gMemoryMap if the GCD type is SystemMemory
or MoreReliable, to avoid spurious errors being reported. This
also avoids the expensive operation of searching through gMemoryMap
for entries we know we will fail to find.

Signed-off-by: Oliver Smith-Denny <o...@linux.microsoft.com>



To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to